CHANGES questions

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

CHANGES questions

Grant Ingersoll-2
I've been reading through CHANGES.txt and had a few questions/comments:

1. The attribute entry still says Token is deprecated.  I can fix, but  
isn't a huge deal.

2. L-1658 talks about changing FSDirectory for SimpleDirectory and  
adds a static open() method, but L-1451 implies I should expect public  
constructors on FSDirectory.  This is confusing.

Thanks,
Grant



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: CHANGES questions

Mark Miller-3
Grant Ingersoll wrote:

> I've been reading through CHANGES.txt and had a few questions/comments:
>
> 1. The attribute entry still says Token is deprecated.  I can fix, but
> isn't a huge deal.
>
> 2. L-1658 talks about changing FSDirectory for SimpleDirectory and
> adds a static open() method, but L-1451 implies I should expect public
> constructors on FSDirectory.  This is confusing.
>
> Thanks,
> Grant
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
Good catches both.

+1 on removing the deprecated token reference (its now a utility class
basically) and merging the entries for L-1658, L-1451so that they are
consistent.

--
- Mark

http://www.lucidimagination.com




---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: CHANGES questions

Mark Miller-3
Mark Miller wrote:
> merging the entries for L-1658, L-1451so that they are
> consistent.
>
>  
Something along the lines of:

 * LUCENE-1658, LUCENE-1451: Renamed FSDirectory to SimpleFSDirectory
    (but left an FSDirectory base class).  Added an FSDirectory.open
    static method to pick a good default FSDirectory implementation
    given the OS. FSDirectories should now be instantiated using
    FSDirectory.open or with public constructors rather than
    FSDirectory.getDirectory(), which has been deprecated.
    (Michael McCandless, Uwe Schindler, yonik)

--
- Mark

http://www.lucidimagination.com




---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

RE: CHANGES questions

Uwe Schindler
In reply to this post by Grant Ingersoll-2
> I've been reading through CHANGES.txt and had a few questions/comments:
>
> 1. The attribute entry still says Token is deprecated.  I can fix, but
> isn't a huge deal.

Another one? +1 for changing.

> 2. L-1658 talks about changing FSDirectory for SimpleDirectory and
> adds a static open() method, but L-1451 implies I should expect public
> constructors on FSDirectory.  This is confusing.

I have seen this, too. I would merge both entries.

Uwe


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: CHANGES questions

Michael McCandless-2
In reply to this post by Mark Miller-3
On Sun, Sep 20, 2009 at 7:40 PM, Mark Miller <[hidden email]> wrote:

> Mark Miller wrote:
>
> Something along the lines of:
>
>  * LUCENE-1658, LUCENE-1451: Renamed FSDirectory to SimpleFSDirectory
>    (but left an FSDirectory base class).  Added an FSDirectory.open
>    static method to pick a good default FSDirectory implementation
>    given the OS. FSDirectories should now be instantiated using
>    FSDirectory.open or with public constructors rather than
>    FSDirectory.getDirectory(), which has been deprecated.
>    (Michael McCandless, Uwe Schindler, yonik)

+1, looks good Mark.  Thanks!

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]