FW: Styles

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

FW: Styles

Markus Jelsma-2
was not sent to list
 
-----Original message-----

> From:Sebastian Nagel <[hidden email]>
> Sent: Saturday 19th August 2017 13:49
> To: Markus Jelsma <[hidden email]>
> Subject: Re: Styles
>
> There are 3 rules regarding empty lines around and between imports in
>    https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml
>
> It would be ideal if the rules are formally defined and could be automatically applied.
> Maybe it's possible to configure the behavior of "Organize Imports" in Eclipse.
> The defaults (group by java, javax, org, com) are only partially useful. Groups for frequent
> prefixes in the Nutch sources (eg. org.apache.nutch, org.apache.hadoop, org.slf4j) would
> be helpful.
>
> Thanks,
> Sebastian
>
>
> On 08/19/2017 12:43 AM, Markus Jelsma wrote:
> > Although it has not troubled me so far, if there is something you think there is to improve i would most certainly welcome it! Feel free to open an issue at our Jira, provide a patch or pull request so it can be dealt with.
> >
> > Regards,
> > Markus
> >  
> > -----Original message-----
> >> From:kenneth mcfarland <[hidden email]>
> >> Sent: Saturday 19th August 2017 0:09
> >> To: [hidden email]
> >> Subject: Styles
> >>
> >> Ive noticed our imports have inconsistent import orderings, is there anyone who would like to see this made consistent? I have the time to work on this, if it is important enough to others as it is to me.
>
>
Reply | Threaded
Open this post in threaded view
|

Re: FW: Styles

Sebastian Nagel
Thanks, Markus.

Sorry, wrong reply button. But should be @dev.

Thanks again!

On 08/19/2017 04:49 PM, Markus Jelsma wrote:

> was not sent to list
>  
> -----Original message-----
>> From:Sebastian Nagel <[hidden email]>
>> Sent: Saturday 19th August 2017 13:49
>> To: Markus Jelsma <[hidden email]>
>> Subject: Re: Styles
>>
>> There are 3 rules regarding empty lines around and between imports in
>>    https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml
>>
>> It would be ideal if the rules are formally defined and could be automatically applied.
>> Maybe it's possible to configure the behavior of "Organize Imports" in Eclipse.
>> The defaults (group by java, javax, org, com) are only partially useful. Groups for frequent
>> prefixes in the Nutch sources (eg. org.apache.nutch, org.apache.hadoop, org.slf4j) would
>> be helpful.
>>
>> Thanks,
>> Sebastian
>>
>>
>> On 08/19/2017 12:43 AM, Markus Jelsma wrote:
>>> Although it has not troubled me so far, if there is something you think there is to improve i would most certainly welcome it! Feel free to open an issue at our Jira, provide a patch or pull request so it can be dealt with.
>>>
>>> Regards,
>>> Markus
>>>  
>>> -----Original message-----
>>>> From:kenneth mcfarland <[hidden email]>
>>>> Sent: Saturday 19th August 2017 0:09
>>>> To: [hidden email]
>>>> Subject: Styles
>>>>
>>>> Ive noticed our imports have inconsistent import orderings, is there anyone who would like to see this made consistent? I have the time to work on this, if it is important enough to others as it is to me.
>>
>>