[GitHub] lucene-solr pull request #287: SOLR-11331: Ability to Debug Solr With Eclips...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] lucene-solr pull request #287: SOLR-11331: Ability to Debug Solr With Eclips...

moshebla
GitHub user mrkarthik opened a pull request:

    https://github.com/apache/lucene-solr/pull/287

    SOLR-11331: Ability to Debug Solr With Eclipse IDE

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mrkarthik/lucene-solr jira/SOLR-11331

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/287.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #287
   
----

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] lucene-solr issue #287: SOLR-11331: Ability to Debug Solr With Eclipse IDE

moshebla
Github user mrkarthik commented on the issue:

    https://github.com/apache/lucene-solr/pull/287
 
    @uschindler I have managed to copy all required folder to eclipse-build, can you review the changes?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] lucene-solr issue #287: SOLR-11331: Ability to Debug Solr With Eclipse IDE

moshebla
In reply to this post by moshebla
Github user mrkarthik commented on the issue:

    https://github.com/apache/lucene-solr/pull/287
 
    I have updated the PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] lucene-solr pull request #287: SOLR-11331: Ability to Debug Solr With Eclips...

moshebla
In reply to this post by moshebla
Github user uschindler commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/287#discussion_r174147473
 
    --- Diff: dev-tools/eclipse/dot.classpath.xsl ---
    @@ -54,7 +55,23 @@
               <classpathentry excluding="src" including="conf/**" kind="src" path="lucene/benchmark"/>
             </xsl:if>
           </xsl:for-each>
    -      
    +  
    --- End diff --
   
    Could you fix the indent here. In Lucene we only allow whitespace, tabs are forbidden anywhere. This looks like it's mixed here (unfortunately I can't see it here)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] lucene-solr pull request #287: SOLR-11331: Ability to Debug Solr With Eclips...

moshebla
In reply to this post by moshebla
Github user vthacker commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/287#discussion_r174149233
 
    --- Diff: dev-tools/eclipse/dot.classpath.xsl ---
    @@ -54,7 +55,23 @@
               <classpathentry excluding="src" including="conf/**" kind="src" path="lucene/benchmark"/>
             </xsl:if>
           </xsl:for-each>
    -      
    +  
    --- End diff --
   
    Hi @uschindler can you please look at the final patch uploaded on the JIra instead. I took Karthik's patch and fixed the whitespace/tabs issues there


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] lucene-solr pull request #287: SOLR-11331: Ability to Debug Solr With Eclips...

moshebla
In reply to this post by moshebla
Github user uschindler commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/287#discussion_r174281383
 
    --- Diff: dev-tools/eclipse/dot.classpath.xsl ---
    @@ -54,7 +55,23 @@
               <classpathentry excluding="src" including="conf/**" kind="src" path="lucene/benchmark"/>
             </xsl:if>
           </xsl:for-each>
    -      
    +  
    --- End diff --
   
    sure!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] lucene-solr issue #287: SOLR-11331: Ability to Debug Solr With Eclipse IDE

moshebla
In reply to this post by moshebla
Github user mrkarthik commented on the issue:

    https://github.com/apache/lucene-solr/pull/287
 
    Code committed by @uschindler. Commit d2152da59482b6cc338c60888b72e8f2996cb86a


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] lucene-solr pull request #287: SOLR-11331: Ability to Debug Solr With Eclips...

moshebla
In reply to this post by moshebla
Github user mrkarthik closed the pull request at:

    https://github.com/apache/lucene-solr/pull/287


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]