[GitHub] lucene-solr pull request #474: SOLR-12880: Show the FacetProcessor class nam...

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] lucene-solr pull request #474: SOLR-12880: Show the FacetProcessor class nam...

cbismuth
GitHub user tpunder opened a pull request:

    https://github.com/apache/lucene-solr/pull/474

    SOLR-12880: Show the FacetProcessor class name in the “processor” field of the JSON Facets “debug-trace” debug output

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tpunder/lucene-solr SOLR-12880

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/474.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #474
   
----
commit 98cb232727c2638215bba4fe4c68ac0530f42346
Author: Tim Underwood <timunderwood@...>
Date:   2018-10-17T20:01:23Z

    SOLR-12880: Show the FacetProcessor class name in the “processor” field of the JSON Facets “debug-trace” debug output

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] lucene-solr issue #474: SOLR-12880: Show the FacetProcessor class name in th...

cbismuth
Github user tpunder commented on the issue:

    https://github.com/apache/lucene-solr/pull/474
 
    This has been updated but for reference here is the original change:
   
    ```diff
    $ git show 98cb232727c2638215bba4fe4c68ac0530f42346
    commit 98cb232727c2638215bba4fe4c68ac0530f42346 (tim/SOLR-12880)
    Author: Tim Underwood <[hidden email]>
    Date:   Wed Oct 17 13:01:23 2018 -0700
   
        SOLR-12880: Show the FacetProcessor class name in the “processor” field of the JSON Facets “debug-trace” debug output
   
    diff --git a/solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java b/solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java
    index 658e0fcffc..4135c87db6 100644
    --- a/solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java
    +++ b/solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java
    @@ -371,7 +371,7 @@ public abstract class FacetRequest {
             debugInfo.setFilter(fcontext.filter.toString());
           }
           debugInfo.setReqDescription(getFacetDescription());
    -      debugInfo.setProcessor(getClass().getSimpleName());
    +      debugInfo.setProcessor(facetProcessor.getClass().getSimpleName());
           debugInfo.putInfoItem("domainSize", (long) fcontext.base.size());
           RTimer timer = new RTimer();
           facetProcessor.process();
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]