[GitHub] [lucene-solr] romseygeek commented on a change in pull request #581: LUCENE-3041: QueryVisitor

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #581: LUCENE-3041: QueryVisitor

GitBox
romseygeek commented on a change in pull request #581: LUCENE-3041: QueryVisitor
URL: https://github.com/apache/lucene-solr/pull/581#discussion_r265173532
 
 

 ##########
 File path: lucene/classification/src/java/org/apache/lucene/classification/utils/NearestFuzzyQuery.java
 ##########
 @@ -327,4 +329,9 @@ private boolean equalsTo(NearestFuzzyQuery other) {
         Objects.equals(fieldVals, other.fieldVals);
   }
 
+  @Override
+  public void visit(QueryVisitor visitor, Predicate<String> fieldSelector) {
 
 Review comment:
   As in, add an `acceptsField` method to QueryVisitor?  What I'm trying to do is to avoid heavy computations in queries like TermInSetQuery when the visitor isn't actually interested in the terms from that query's field.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]