Next move with JIRA ticket

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Next move with JIRA ticket

Ned Rockson-3
I submitted a JIRA ticket regarding URL ordering in Generator.java as
well as a patch (NUTCH-570) and I'm wondering what else I need to do to
get this committed.  Obviously it's low priority so I may be getting too
antsy.
Reply | Threaded
Open this post in threaded view
|

Re: Next move with JIRA ticket

Doğacan Güney-3
Hi,

On 10/31/07, Ned Rockson <[hidden email]> wrote:
> I submitted a JIRA ticket regarding URL ordering in Generator.java as
> well as a patch (NUTCH-570) and I'm wondering what else I need to do to
> get this committed.  Obviously it's low priority so I may be getting too
> antsy.
>

Since NUTCH-570 tracks a non-trivial change and nutch development  is
a bit slow these days, it may be a while before someone can review
your patch and make a comment on it. Personally, I have been meaning
to take a look at your patch, but I have been too lazy^Wbusy lately.

What you can do is that, for example, you can send some statistics
regarding overhead of running two extra jobs or fetch performance
increase as a result of smarter url ordering. Again personally, I find
that patches with such numbers and test cases are a lot easier to
review (thus, easier to commit:).

--
Doğacan Güney
Reply | Threaded
Open this post in threaded view
|

Re: Next move with JIRA ticket

Ned Rockson
Thanks for the information.  I'll have to run a fresh fetch to get
some correct stats so I'll submit it in a day or two.

On 10/31/07, Doğacan Güney <[hidden email]> wrote:

> Hi,
>
> On 10/31/07, Ned Rockson <[hidden email]> wrote:
> > I submitted a JIRA ticket regarding URL ordering in Generator.java as
> > well as a patch (NUTCH-570) and I'm wondering what else I need to do to
> > get this committed.  Obviously it's low priority so I may be getting too
> > antsy.
> >
>
> Since NUTCH-570 tracks a non-trivial change and nutch development  is
> a bit slow these days, it may be a while before someone can review
> your patch and make a comment on it. Personally, I have been meaning
> to take a look at your patch, but I have been too lazy^Wbusy lately.
>
> What you can do is that, for example, you can send some statistics
> regarding overhead of running two extra jobs or fetch performance
> increase as a result of smarter url ordering. Again personally, I find
> that patches with such numbers and test cases are a lot easier to
> review (thus, easier to commit:).
>
> --
> Doğacan Güney
>