RE: svn commit: r1388844 - /lucene/dev/branches/lucene_solr_4_0/dev-tools/scripts/smokeTestRelease.py

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RE: svn commit: r1388844 - /lucene/dev/branches/lucene_solr_4_0/dev-tools/scripts/smokeTestRelease.py

Uwe Schindler
I would invert that check to test for *.xml.template.

Uwe

-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: [hidden email]


> -----Original Message-----
> From: [hidden email] [mailto:[hidden email]]
> Sent: Saturday, September 22, 2012 7:04 PM
> To: [hidden email]
> Subject: svn commit: r1388844 - /lucene/dev/branches/lucene_solr_4_0/dev-
> tools/scripts/smokeTestRelease.py
>
> Author: mikemccand
> Date: Sat Sep 22 17:04:14 2012
> New Revision: 1388844
>
> URL: http://svn.apache.org/viewvc?rev=1388844&view=rev
> Log:
> hack: skip .properties from POM checking; really we need to figure out why
> .properties is in POMtemplates[project] to begin with...
>
> Modified:
>     lucene/dev/branches/lucene_solr_4_0/dev-
> tools/scripts/smokeTestRelease.py
>
> Modified: lucene/dev/branches/lucene_solr_4_0/dev-
> tools/scripts/smokeTestRelease.py
> URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_4_0/dev-
> tools/scripts/smokeTestRelease.py?rev=1388844&r1=1388843&r2=1388844&vi
> ew=diff
> ================================================================
> ==============
> --- lucene/dev/branches/lucene_solr_4_0/dev-
> tools/scripts/smokeTestRelease.py (original)
> +++ lucene/dev/branches/lucene_solr_4_0/dev-
> tools/scripts/smokeTestRelease.py Sat Sep 22 17:04:14 2012
> @@ -982,6 +982,8 @@ def verifyArtifactPerPOMtemplate(POMtemp
>    xpathSkipConfiguration = '{0}configuration/{0}skip'.format(namespace)
>    for project in ('lucene', 'solr'):
>      for POMtemplate in POMtemplates[project]:
> +      if POMtemplate.endswith('.properties'):
> +        continue
>        print('      Checking POM template %s' % POMtemplate)
>        treeRoot = ET.parse(POMtemplate).getroot()
>        skipDeploy = False



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1388844 - /lucene/dev/branches/lucene_solr_4_0/dev-tools/scripts/smokeTestRelease.py

Michael McCandless-2
OK I inverted it :)

Hopefully Steve will come to the rescue with the proper fix!

Mike McCandless

http://blog.mikemccandless.com

On Sat, Sep 22, 2012 at 1:07 PM, Uwe Schindler <[hidden email]> wrote:

> I would invert that check to test for *.xml.template.
>
> Uwe
>
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: [hidden email]
>
>
>> -----Original Message-----
>> From: [hidden email] [mailto:[hidden email]]
>> Sent: Saturday, September 22, 2012 7:04 PM
>> To: [hidden email]
>> Subject: svn commit: r1388844 - /lucene/dev/branches/lucene_solr_4_0/dev-
>> tools/scripts/smokeTestRelease.py
>>
>> Author: mikemccand
>> Date: Sat Sep 22 17:04:14 2012
>> New Revision: 1388844
>>
>> URL: http://svn.apache.org/viewvc?rev=1388844&view=rev
>> Log:
>> hack: skip .properties from POM checking; really we need to figure out why
>> .properties is in POMtemplates[project] to begin with...
>>
>> Modified:
>>     lucene/dev/branches/lucene_solr_4_0/dev-
>> tools/scripts/smokeTestRelease.py
>>
>> Modified: lucene/dev/branches/lucene_solr_4_0/dev-
>> tools/scripts/smokeTestRelease.py
>> URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_4_0/dev-
>> tools/scripts/smokeTestRelease.py?rev=1388844&r1=1388843&r2=1388844&vi
>> ew=diff
>> ================================================================
>> ==============
>> --- lucene/dev/branches/lucene_solr_4_0/dev-
>> tools/scripts/smokeTestRelease.py (original)
>> +++ lucene/dev/branches/lucene_solr_4_0/dev-
>> tools/scripts/smokeTestRelease.py Sat Sep 22 17:04:14 2012
>> @@ -982,6 +982,8 @@ def verifyArtifactPerPOMtemplate(POMtemp
>>    xpathSkipConfiguration = '{0}configuration/{0}skip'.format(namespace)
>>    for project in ('lucene', 'solr'):
>>      for POMtemplate in POMtemplates[project]:
>> +      if POMtemplate.endswith('.properties'):
>> +        continue
>>        print('      Checking POM template %s' % POMtemplate)
>>        treeRoot = ET.parse(POMtemplate).getroot()
>>        skipDeploy = False
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

RE: svn commit: r1388844 - /lucene/dev/branches/lucene_solr_4_0/dev-tools/scripts/smokeTestRelease.py

Uwe Schindler
I fit works, can you forward port (and remove the print again)? I wanted to run the 4.x and trunk checker, too - so Robert gets happy with my groovy scripts.

Uwe

-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: [hidden email]


> -----Original Message-----
> From: Michael McCandless [mailto:[hidden email]]
> Sent: Saturday, September 22, 2012 7:10 PM
> To: [hidden email]
> Subject: Re: svn commit: r1388844 -
> /lucene/dev/branches/lucene_solr_4_0/dev-tools/scripts/smokeTestRelease.py
>
> OK I inverted it :)
>
> Hopefully Steve will come to the rescue with the proper fix!
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
> On Sat, Sep 22, 2012 at 1:07 PM, Uwe Schindler <[hidden email]> wrote:
> > I would invert that check to test for *.xml.template.
> >
> > Uwe
> >
> > -----
> > Uwe Schindler
> > H.-H.-Meier-Allee 63, D-28213 Bremen
> > http://www.thetaphi.de
> > eMail: [hidden email]
> >
> >
> >> -----Original Message-----
> >> From: [hidden email] [mailto:[hidden email]]
> >> Sent: Saturday, September 22, 2012 7:04 PM
> >> To: [hidden email]
> >> Subject: svn commit: r1388844 -
> >> /lucene/dev/branches/lucene_solr_4_0/dev-
> >> tools/scripts/smokeTestRelease.py
> >>
> >> Author: mikemccand
> >> Date: Sat Sep 22 17:04:14 2012
> >> New Revision: 1388844
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1388844&view=rev
> >> Log:
> >> hack: skip .properties from POM checking; really we need to figure
> >> out why .properties is in POMtemplates[project] to begin with...
> >>
> >> Modified:
> >>     lucene/dev/branches/lucene_solr_4_0/dev-
> >> tools/scripts/smokeTestRelease.py
> >>
> >> Modified: lucene/dev/branches/lucene_solr_4_0/dev-
> >> tools/scripts/smokeTestRelease.py
> >> URL:
> >> http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_4_0/dev-
> >>
> tools/scripts/smokeTestRelease.py?rev=1388844&r1=1388843&r2=1388844&v
> >> i
> >> ew=diff
> >>
> ================================================================
> >> ==============
> >> --- lucene/dev/branches/lucene_solr_4_0/dev-
> >> tools/scripts/smokeTestRelease.py (original)
> >> +++ lucene/dev/branches/lucene_solr_4_0/dev-
> >> tools/scripts/smokeTestRelease.py Sat Sep 22 17:04:14 2012 @@ -982,6
> >> +982,8 @@ def verifyArtifactPerPOMtemplate(POMtemp
> >>    xpathSkipConfiguration = '{0}configuration/{0}skip'.format(namespace)
> >>    for project in ('lucene', 'solr'):
> >>      for POMtemplate in POMtemplates[project]:
> >> +      if POMtemplate.endswith('.properties'):
> >> +        continue
> >>        print('      Checking POM template %s' % POMtemplate)
> >>        treeRoot = ET.parse(POMtemplate).getroot()
> >>        skipDeploy = False
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email] For
> > additional commands, e-mail: [hidden email]
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email] For additional
> commands, e-mail: [hidden email]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1388844 - /lucene/dev/branches/lucene_solr_4_0/dev-tools/scripts/smokeTestRelease.py

Michael McCandless-2
OK will do.

Let's wait and see how smoke tester does...

Mike McCandless

http://blog.mikemccandless.com

On Sat, Sep 22, 2012 at 1:14 PM, Uwe Schindler <[hidden email]> wrote:

> I fit works, can you forward port (and remove the print again)? I wanted to run the 4.x and trunk checker, too - so Robert gets happy with my groovy scripts.
>
> Uwe
>
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: [hidden email]
>
>
>> -----Original Message-----
>> From: Michael McCandless [mailto:[hidden email]]
>> Sent: Saturday, September 22, 2012 7:10 PM
>> To: [hidden email]
>> Subject: Re: svn commit: r1388844 -
>> /lucene/dev/branches/lucene_solr_4_0/dev-tools/scripts/smokeTestRelease.py
>>
>> OK I inverted it :)
>>
>> Hopefully Steve will come to the rescue with the proper fix!
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>> On Sat, Sep 22, 2012 at 1:07 PM, Uwe Schindler <[hidden email]> wrote:
>> > I would invert that check to test for *.xml.template.
>> >
>> > Uwe
>> >
>> > -----
>> > Uwe Schindler
>> > H.-H.-Meier-Allee 63, D-28213 Bremen
>> > http://www.thetaphi.de
>> > eMail: [hidden email]
>> >
>> >
>> >> -----Original Message-----
>> >> From: [hidden email] [mailto:[hidden email]]
>> >> Sent: Saturday, September 22, 2012 7:04 PM
>> >> To: [hidden email]
>> >> Subject: svn commit: r1388844 -
>> >> /lucene/dev/branches/lucene_solr_4_0/dev-
>> >> tools/scripts/smokeTestRelease.py
>> >>
>> >> Author: mikemccand
>> >> Date: Sat Sep 22 17:04:14 2012
>> >> New Revision: 1388844
>> >>
>> >> URL: http://svn.apache.org/viewvc?rev=1388844&view=rev
>> >> Log:
>> >> hack: skip .properties from POM checking; really we need to figure
>> >> out why .properties is in POMtemplates[project] to begin with...
>> >>
>> >> Modified:
>> >>     lucene/dev/branches/lucene_solr_4_0/dev-
>> >> tools/scripts/smokeTestRelease.py
>> >>
>> >> Modified: lucene/dev/branches/lucene_solr_4_0/dev-
>> >> tools/scripts/smokeTestRelease.py
>> >> URL:
>> >> http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_4_0/dev-
>> >>
>> tools/scripts/smokeTestRelease.py?rev=1388844&r1=1388843&r2=1388844&v
>> >> i
>> >> ew=diff
>> >>
>> ================================================================
>> >> ==============
>> >> --- lucene/dev/branches/lucene_solr_4_0/dev-
>> >> tools/scripts/smokeTestRelease.py (original)
>> >> +++ lucene/dev/branches/lucene_solr_4_0/dev-
>> >> tools/scripts/smokeTestRelease.py Sat Sep 22 17:04:14 2012 @@ -982,6
>> >> +982,8 @@ def verifyArtifactPerPOMtemplate(POMtemp
>> >>    xpathSkipConfiguration = '{0}configuration/{0}skip'.format(namespace)
>> >>    for project in ('lucene', 'solr'):
>> >>      for POMtemplate in POMtemplates[project]:
>> >> +      if POMtemplate.endswith('.properties'):
>> >> +        continue
>> >>        print('      Checking POM template %s' % POMtemplate)
>> >>        treeRoot = ET.parse(POMtemplate).getroot()
>> >>        skipDeploy = False
>> >
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: [hidden email] For
>> > additional commands, e-mail: [hidden email]
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email] For additional
>> commands, e-mail: [hidden email]
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

RE: svn commit: r1388844 - /lucene/dev/branches/lucene_solr_4_0/dev-tools/scripts/smokeTestRelease.py

steve_rowe
In reply to this post by Michael McCandless-2
Thanks Mike,

I switched to properly populating POMtemplates, and removed the debug printing.  Committed to the release branch, branch_4x, and trunk.

I also enabled running the smoke tester under Cygwin again.  It passed for me using the 'ant nightly-smoke'-produced fake release.

Steve

-----Original Message-----
From: Michael McCandless [mailto:[hidden email]]
Sent: Saturday, September 22, 2012 1:10 PM
To: [hidden email]
Subject: Re: svn commit: r1388844 - /lucene/dev/branches/lucene_solr_4_0/dev-tools/scripts/smokeTestRelease.py

OK I inverted it :)

Hopefully Steve will come to the rescue with the proper fix!

Mike McCandless

http://blog.mikemccandless.com

On Sat, Sep 22, 2012 at 1:07 PM, Uwe Schindler <[hidden email]> wrote:

> I would invert that check to test for *.xml.template.
>
> Uwe
>
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: [hidden email]
>
>
>> -----Original Message-----
>> From: [hidden email] [mailto:[hidden email]]
>> Sent: Saturday, September 22, 2012 7:04 PM
>> To: [hidden email]
>> Subject: svn commit: r1388844 -
>> /lucene/dev/branches/lucene_solr_4_0/dev-
>> tools/scripts/smokeTestRelease.py
>>
>> Author: mikemccand
>> Date: Sat Sep 22 17:04:14 2012
>> New Revision: 1388844
>>
>> URL: http://svn.apache.org/viewvc?rev=1388844&view=rev
>> Log:
>> hack: skip .properties from POM checking; really we need to figure
>> out why .properties is in POMtemplates[project] to begin with...
>>
>> Modified:
>>     lucene/dev/branches/lucene_solr_4_0/dev-
>> tools/scripts/smokeTestRelease.py
>>
>> Modified: lucene/dev/branches/lucene_solr_4_0/dev-
>> tools/scripts/smokeTestRelease.py
>> URL:
>> http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_4_0/dev-
>> tools/scripts/smokeTestRelease.py?rev=1388844&r1=1388843&r2=1388844&v
>> i
>> ew=diff
>> ================================================================
>> ==============
>> --- lucene/dev/branches/lucene_solr_4_0/dev-
>> tools/scripts/smokeTestRelease.py (original)
>> +++ lucene/dev/branches/lucene_solr_4_0/dev-
>> tools/scripts/smokeTestRelease.py Sat Sep 22 17:04:14 2012 @@ -982,6
>> +982,8 @@ def verifyArtifactPerPOMtemplate(POMtemp
>>    xpathSkipConfiguration = '{0}configuration/{0}skip'.format(namespace)
>>    for project in ('lucene', 'solr'):
>>      for POMtemplate in POMtemplates[project]:
>> +      if POMtemplate.endswith('.properties'):
>> +        continue
>>        print('      Checking POM template %s' % POMtemplate)
>>        treeRoot = ET.parse(POMtemplate).getroot()
>>        skipDeploy = False
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email] For
> additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email] For additional commands, e-mail: [hidden email]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]