Re: [Nutch-cvs] svn commit: r280368 - /lucene/nutch/branches/mapred/src/java/org/apache/nutch/fs/TestClient.java

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Nutch-cvs] svn commit: r280368 - /lucene/nutch/branches/mapred/src/java/org/apache/nutch/fs/TestClient.java

Andrzej Białecki-2
[hidden email] wrote:
> Author: cutting
> Date: Mon Sep 12 10:03:00 2005
> New Revision: 280368
>
> URL: http://svn.apache.org/viewcvs?rev=280368&view=rev
> Log:
> Change so that -du and -ls commands work with zero arguments.

Come to think of that... Shouldn't the enigmatic "TestClient" be renamed
to something like NDFSShell or something like this? Tests are placed
somewhere else, so the name of this class doesn't fit here (and IMHO it
should stay here, or perhaps in tools/).


--
Best regards,
Andrzej Bialecki     <><
  ___. ___ ___ ___ _ _   __________________________________
[__ || __|__/|__||\/|  Information Retrieval, Semantic Web
___|||__||  \|  ||  |  Embedded Unix, System Integration
http://www.sigram.com  Contact: info at sigram dot com

Reply | Threaded
Open this post in threaded view
|

Re: [Nutch-cvs] svn commit: r280368 - /lucene/nutch/branches/mapred/src/java/org/apache/nutch/fs/TestClient.java

Doug Cutting-2
Andrzej Bialecki wrote:
> Come to think of that... Shouldn't the enigmatic "TestClient" be renamed
> to something like NDFSShell or something like this? Tests are placed
> somewhere else, so the name of this class doesn't fit here (and IMHO it
> should stay here, or perhaps in tools/).

Yes, TestClient is a bad name.  NDFSShell would be better.  I would also
vote to move it to the ndfs package, along with NDFSFileSystem.java.

Doug