Re: svn commit: r168450 - in /lucene/java/trunk/src/java/org/apache/lucene: index/SegmentMerger.java search/MultiPhraseQuery.java search/MultiSearcher.java search/PhrasePrefixQuery.java search/PhraseQuery.java search/TermQuery.java

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r168450 - in /lucene/java/trunk/src/java/org/apache/lucene: index/SegmentMerger.java search/MultiPhraseQuery.java search/MultiSearcher.java search/PhrasePrefixQuery.java search/PhraseQuery.java search/TermQuery.java

Doug Cutting
[hidden email] wrote:
> don't declare Exceptions that are never thrown; remove an unused variable

When these are implementing a pubic interface or abstract method I think
it is good to keep the exception declaration, as it is a part of the
interface.  That way, if an exception needs to be thrown in the future,
the developer knows what types are permitted.

Doug





---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r168450 - in /lucene/java/trunk/src/java/org/apache/lucene: index/SegmentMerger.java search/MultiPhraseQuery.java search/MultiSearcher.java search/PhrasePrefixQuery.java search/PhraseQuery.java search/TermQuery.java

Daniel Naber
On Friday 06 May 2005 20:00, Doug Cutting wrote:

> When these are implementing a pubic interface or abstract method I think
> it is good to keep the exception declaration, as it is a part of the
> interface.

Yes, I'm aware of that. All my changes (unless I made a mistake) only
affected private or final methods or methods inside inner private classes.

Regards
 Daniel

--
http://www.danielnaber.de

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]