SpanNearQuery .equals()/.hash()

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

SpanNearQuery .equals()/.hash()

Michael-61
Hi,

It seems to me SpanNearQuery.equals()/.hash() are not overriden
because I've tried testing two logically equivalent queries but
.equals() returns false. Could anyone provide an implementation?

Cheers,

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: SpanNearQuery .equals()/.hash()

Erik Hatcher
What version of Lucene are you using?   It should work fine with  
1.9.  If not, could you supply a test case demonstrating this issue?

Thanks,
        Erik



On May 5, 2006, at 10:13 AM, Michael Chan wrote:

> Hi,
>
> It seems to me SpanNearQuery.equals()/.hash() are not overriden
> because I've tried testing two logically equivalent queries but
> .equals() returns false. Could anyone provide an implementation?
>
> Cheers,
>
> Michael
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: SpanNearQuery .equals()/.hash()

Michael-61
Hi,

I'm using the latest version. Try the following:

                                SpanQuery[] clauses1 = {new SpanTermQuery(new Term("contents",
"test1")), new SpanTermQuery(new Term("contents", "test2"))};
                                SpanNearQuery nearQ1 = new SpanNearQuery(clauses1, 3, false);

                                SpanQuery[] clauses2 = {new SpanTermQuery(new Term("contents",
"test2")), new SpanTermQuery(new Term("contents", "test1"))};
                                SpanNearQuery nearQ2 = new SpanNearQuery(clauses2, 3, false);

                                System.out.println(nearQ1.equals(nearQ2));

It works if clauses2 = {new SpanTermQuery(new Term("contents",
"test1")), new SpanTermQuery(new Term("contents", "test2"))}. But,
since order doesn't matter here, the two queries should be equal,
right?

Cheers,

Michael


On 5/6/06, Erik Hatcher <[hidden email]> wrote:

> What version of Lucene are you using?   It should work fine with
> 1.9.  If not, could you supply a test case demonstrating this issue?
>
> Thanks,
>         Erik
>
>
>
> On May 5, 2006, at 10:13 AM, Michael Chan wrote:
>
> > Hi,
> >
> > It seems to me SpanNearQuery.equals()/.hash() are not overriden
> > because I've tried testing two logically equivalent queries but
> > .equals() returns false. Could anyone provide an implementation?
> >
> > Cheers,
> >
> > Michael
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: SpanNearQuery .equals()/.hash()

Yonik Seeley
Yes, most of Lucene's Query equals() and hashCode() methods consider
clause order important (including BooleanQuery).  It's like
List.equals() vs Set.equals()

I'm not sure if it's worth fixing them all or not... implementing set
equality with an underlying list can certainly be more expensive (some
kind of HashSet would be more efficient for that).

Users can also get this behavior by normalizing or sorting clauses.

-Yonik
http://incubator.apache.org/solr Solr, the open-source Lucene search server


On 5/6/06, Michael Chan <[hidden email]> wrote:

> Hi,
>
> I'm using the latest version. Try the following:
>
>                                 SpanQuery[] clauses1 = {new SpanTermQuery(new Term("contents",
> "test1")), new SpanTermQuery(new Term("contents", "test2"))};
>                                 SpanNearQuery nearQ1 = new SpanNearQuery(clauses1, 3, false);
>
>                                 SpanQuery[] clauses2 = {new SpanTermQuery(new Term("contents",
> "test2")), new SpanTermQuery(new Term("contents", "test1"))};
>                                 SpanNearQuery nearQ2 = new SpanNearQuery(clauses2, 3, false);
>
>                                 System.out.println(nearQ1.equals(nearQ2));
>
> It works if clauses2 = {new SpanTermQuery(new Term("contents",
> "test1")), new SpanTermQuery(new Term("contents", "test2"))}. But,
> since order doesn't matter here, the two queries should be equal,
> right?
>
> Cheers,
>
> Michael
>
>
> On 5/6/06, Erik Hatcher <[hidden email]> wrote:
> > What version of Lucene are you using?   It should work fine with
> > 1.9.  If not, could you supply a test case demonstrating this issue?
> >
> > Thanks,
> >         Erik
> >
> >
> >
> > On May 5, 2006, at 10:13 AM, Michael Chan wrote:
> >
> > > Hi,
> > >
> > > It seems to me SpanNearQuery.equals()/.hash() are not overriden
> > > because I've tried testing two logically equivalent queries but
> > > .equals() returns false. Could anyone provide an implementation?
> > >
> > > Cheers,
> > >
> > > Michael
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: SpanNearQuery .equals()/.hash()

Chris Hostetter-3

: I'm not sure if it's worth fixing them all or not... implementing set

i'm -1 against making this change.  The results of searching on these
query objects may be the same -- but that doesn't mean the query objects
themselves should be considered equivilent.  attempting to define them as
equal would lead to a slippery slope of trying to determine that any two
queries (possibly implimented by different classes) are "equal" because
they produce the same results.

Assume that (hypothetically) a SpanNearQuery containing two
SpanTermQueries with inOrder=1 and slop=0 scores *exactly* the same as a
PhraseQuery with 0 slop containing the same two terms.  SHould these
queries be considered equal ?




-Hoss


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]