[jira] [Comment Edited] (LUCENE-8273) Add a ConditionalTokenFilter

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (LUCENE-8273) Add a ConditionalTokenFilter

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477590#comment-16477590 ]

Steve Rowe edited comment on LUCENE-8273 at 5/16/18 3:42 PM:
-------------------------------------------------------------

Attaching an updated version of my part2 patch.  Changes:
* Added a Solr test and ref guide text for {{ProtectedTermFilterFactory}}
* Moved the failing read-ahead test over to {{TestConditionalFilter}}
* In {{TestConditionalFilter}}, converted most {{CannedTokenStream}}'s to {{MockTokenizer}}'s, which causes error {{IllegalStateException: end() called in wrong state=END!}} - I'm guessing you already know about this and are working on it
* Except for the {{end()}}-related failures, tests succeed
* Precommit succeeds



was (Author: steve_rowe):
Attaching an updated version of my part2 patch.  Changes:
* Added a Solr test and ref guide text for {{ProtectedTermFilterFactory}}
* Moved the failing read-ahead test ved over to {{TestConditionalFilter}}
* In {{TestConditionalFilter}}, converted most {{CannedTokenStream}}'s to {{MockTokenizer}}'s, which causes error {{IllegalStateException: end() called in wrong state=END!}} - I'm guessing you already know about this and are working on it
* Except for the {{end()}}-related failures, tests succeed
* Precommit succeeds


> Add a ConditionalTokenFilter
> ----------------------------
>
>                 Key: LUCENE-8273
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8273
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Major
>             Fix For: 7.4
>
>         Attachments: LUCENE-8273-part2.patch, LUCENE-8273-part2.patch, LUCENE-8273.patch, LUCENE-8273.patch, LUCENE-8273.patch, LUCENE-8273.patch, LUCENE-8273.patch, LUCENE-8273.patch, LUCENE-8273.patch, LUCENE-8273.patch
>
>
> Spinoff of LUCENE-8265.  It would be useful to be able to wrap a TokenFilter in such a way that it could optionally be bypassed based on the current state of the TokenStream.  This could be used to, for example, only apply WordDelimiterFilter to terms that contain hyphens.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]