[jira] [Comment Edited] (SOLR-9509) Fix problems in shell scripts reported by "shellcheck"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Comment Edited] (SOLR-9509) Fix problems in shell scripts reported by "shellcheck"

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025547#comment-16025547 ]

Kuro Kurosaka edited comment on SOLR-9509 at 6/19/17 7:42 AM:
--------------------------------------------------------------

I've submitted a patch. This patch only includes mods to the bin/solr script. It has been lightly tested. Is there a test suite for the bin/solr script that I can run?[~janhoy],[~erickerickson]?



was (Author: tkurosaka):
I've submitted a patch. This patch only includes mods to the bin/solr script. It has been lightly tested. Is there a test suite for the bin/solr script that I can run?


> Fix problems in shell scripts reported by "shellcheck"
> ------------------------------------------------------
>
>                 Key: SOLR-9509
>                 URL: https://issues.apache.org/jira/browse/SOLR-9509
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public)
>          Components: scripts and tools
>            Reporter: Jan H√łydahl
>              Labels: newdev
>         Attachments: bin_solr_shellcheck.txt, shellcheck_solr_20160915.txt, shellcheck_solr_bin_bash_20160915.txt, shellcheck_solr_bin_sh_20160915.txt, shellcheck_solr_usr_bin_env_bash_20160915.txt, SOLR-9509.patch
>
>
> Running {{shellcheck}} on our shell scripts reveal various improvements we should consider.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...