[jira] Commented: (LUCENE-2213) Small improvements to ArrayUtil.getNextSize

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2213) Small improvements to ArrayUtil.getNextSize

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887801#action_12887801 ]

Shai Erera commented on LUCENE-2213:
------------------------------------

I'm not vehemently against anything :). It's just that in the rest of our classes (or at least UnicodeUtil, which I was reading few minutes ago) we didn't follow that behavior, so why with this one?

> Small improvements to ArrayUtil.getNextSize
> -------------------------------------------
>
>                 Key: LUCENE-2213
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2213
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2213-mergetest.patch, LUCENE-2213.patch, LUCENE-2213.patch, LUCENE-2213.patch, LUCENE-2213.patch
>
>
> Spinoff from java-dev thread "Dynamic array reallocation algorithms" started on Jan 12, 2010.
> Here's what I did:
>   * Keep the +3 for small sizes
>   * Added 2nd arg = number of bytes per element.
>   * Round up to 4 or 8 byte boundary (if it's 32 or 64 bit JRE respectively)
>   * Still grow by 1/8th
>   * If 0 is passed in, return 0 back
> I also had to remove some asserts in tests that were checking the actual values returned by this method -- I don't think we should test that (it's an impl. detail).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]