[jira] [Commented] (LUCENE-4848) Add Directory implementations using NIO2 APIs

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (LUCENE-4848) Add Directory implementations using NIO2 APIs

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607585#comment-13607585 ]

Dawid Weiss commented on LUCENE-4848:

bq. We can't even figure out from looking at their stacks where they come from since they are just from a generic Executor.

I think we can safely ignore those that spin inside the internal loop -- see my patch. I know the sysprop is documented in the contract but if we don't have to I'd rather not substitute the defaults. This has an additional benefit that we'll see how other vendors implement these :)

I'm not saying your patch was wrong or anything, I'm just opting for "ignoring" instead of "manipulating to work" strategy.

bq. Someone already did asynch io causing the pool to be created before LuceneTestCase. The tests should pass since the threads exist beforehand.

This depends on which threadpool is actually used for the default. By default (from what I can see in JDK code) these threads are not eagerly allocated so it'd still result in thread leaks because there would be more threads upon leaving the test case than there were when it was started. Like I said, it's not the main reason I would like to keep it defensive and filter rather than substitute the default factory.


> Add Directory implementations using NIO2 APIs
> ---------------------------------------------
>                 Key: LUCENE-4848
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4848
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Michael Poindexter
>            Assignee: Uwe Schindler
>            Priority: Minor
>         Attachments: jdk7directory.zip, LUCENE-4848-MMapDirectory.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch.txt
> I have implemented 3 Directory subclasses using NIO2 API's (available on JDK7).  These may be suitable for inclusion in a Lucene contrib module.
> See the mailing list at http://lucene.markmail.org/thread/lrv7miivzmjm3ml5 for more details about this code and the advantages it provides.
> The code is attached as a zip to this issue.  I'll be happy to make any changes requested.  I've included some minimal smoke tests, but any help in how to use the normal Lucene tests to perform more thorough testing would be appreciated.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]