[jira] [Commented] (LUCENE-7970) Improve generation of circle plane

Previous Topic Next Topic
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (LUCENE-7970) Improve generation of circle plane

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166061#comment-16166061 ]

Karl Wright commented on LUCENE-7970:

[~ivera]: isWithin() for any plane on a non-spherical ellipsoid will generate "true" for an area that is an ellipse.  See:


This is almost certainly the cause for the claim that points around the edge of a GeoCircle are incorrectly described as in-set or out-of-set, when you apply the Vincenti formula to perform the surface distance computation.

Since there are no "generated" points for a geo circle except maybe in the testing framework, I can't see how adding a point generation method helps this in any way.  Please clarify.

> Improve generation of circle plane
> -----------------------------------
>                 Key: LUCENE-7970
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7970
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
> Hi [~Karl wright],
> How circles are currently build do not behave very well when the planet model is not an sphere. when you are close to the border in WGS84 you might get false positves or false negatives when checking if a point is WITHIN. I think the reason is how the points to generate the circle plane are generated which assumes a sphere.
> My proposal is the following:
> Add a new method to PlanetModel:  
> public GeoPoint pointOnBearing(GeoPoint from, double dist, double bearing);
> Which uses and algorithm that takes into account that the planet might not be spherical. For example Vincenty's formulae (https://en.wikipedia.org/wiki/Vincenty%27s_formulae).
> Use this method to generate the points for the circle plane. My experiments shows that this approach removes false negatives in WGS84 meanwhile it works nicely in the Sphere.
> Does it make sense?

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]