[jira] [Commented] (LUCENE-8082) Fix NPE on TopFieldCollectors created with trackTotalHits=false

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-8082) Fix NPE on TopFieldCollectors created with trackTotalHits=false

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281830#comment-16281830 ]

ASF subversion and git services commented on LUCENE-8082:
---------------------------------------------------------

Commit 8d1201ec957a5699bf11ef1000cf4395252d9694 in lucene-solr's branch refs/heads/branch_7x from [~jimczi]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8d1201e ]

LUCENE-8082: Fix NPE in TopFieldCollectors that don't track total hit count


> Fix NPE on TopFieldCollectors created with trackTotalHits=false
> ---------------------------------------------------------------
>
>                 Key: LUCENE-8082
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8082
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Jim Ferenczi
>            Priority: Blocker
>             Fix For: master (8.0), 7.2
>
>         Attachments: LUCENE-8082.patch
>
>
> `TopFieldCollectors` are now able to early terminate queries if the index sort matches the search sort. The collector checks the index sort only if it was created with `trackTotalHits=false` but it fails with an NPE if the index is not sorted (index sort is null). We should let users set `trackTotalHits` to false even if the index is not sorted, in such case early termination is not applicable but the collection should work.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]