[jira] [Commented] (LUCENE-8253) ForceMergeDeletes does not merge soft-deleted segments

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (LUCENE-8253) ForceMergeDeletes does not merge soft-deleted segments

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-8253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439517#comment-16439517 ]

ASF subversion and git services commented on LUCENE-8253:

Commit aeac55a602980c92ffee25602c6450e40eab6e6f in lucene-solr's branch refs/heads/branch_7x from [~simonw]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=aeac55a ]

LUCENE-8253: Account for soft-deletes before they are flushed to disk

Inside the IndexWriter buffers are only written to disk if it's needed
or "worth it" which doesn't guarantee soft deletes to be accounted
in time. This is not necessarily a problem since they are eventually
collected and segments that have soft-deletes will me merged eventually
but for tests and on par behavior compared to hard deletes this behavior
is tricky.
This change cuts over to accounting in-place just like hard-deletes. This
results in accurate delete numbers for soft deletes at any give point in time
once the reader is loaded or a pending soft delete occurs.

This change also fixes an issue where all updates to a DV field are allowed
event if the field is unknown. Now this only works if the field is equal
to the soft deletes field. This behavior was never released.

> ForceMergeDeletes does not merge soft-deleted segments
> ------------------------------------------------------
>                 Key: LUCENE-8253
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8253
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Nhat Nguyen
>            Priority: Major
>         Attachments: LUCENE-8253.patch, test-merge.patch
> IndexWriter#forceMergeDeletes should merge segments having soft-deleted documents as hard-deleted documents if we configured "softDeletesField" in an IndexWriterConfig.
> Attached is a failed test.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]