[jira] [Commented] (LUCENE-8268) MatchesIterator.term() should return an array

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-8268) MatchesIterator.term() should return an array

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447948#comment-16447948 ]

Simon Willnauer commented on LUCENE-8268:
-----------------------------------------

{quote}
So at the moment there isn't anything that actually uses this. My reason for adding it was to make it possible to identify the leaf query that returned each position, but maybe it would be a better idea to remove terms() entirely, and add a getLeafQuery() method instead?
{quote}

hard to tell since I don't know the API well enough. But if this is the purpose, I agree.

> MatchesIterator.term() should return an array
> ---------------------------------------------
>
>                 Key: LUCENE-8268
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8268
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Major
>         Attachments: LUCENE-8268.patch
>
>
> At the moment, we return a single BytesRef from MatchesIterator.term(), which works well for the queries that currently implement this.  This won't be enough for queries that operate on more than one term, however, such as phrase or Span queries.
> In preparation for LUCENE-8249, this issue will change the method to return an array of BytesRef



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]