[jira] [Commented] (LUCENE-8364) Refactor and clean up core geo api

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-8364) Refactor and clean up core geo api

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518740#comment-16518740 ]

Nicholas Knize commented on LUCENE-8364:
----------------------------------------

Thanks [~dsmiley]  No worries. And thanks for opening the discussion. In the meantime I'm hoping this provides the next natural step to making the existing API's more approachable, manageable, and extendable.

> Refactor and clean up core geo api
> ----------------------------------
>
>                 Key: LUCENE-8364
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8364
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Nicholas Knize
>            Priority: Major
>         Attachments: LUCENE-8364.patch
>
>
> The core geo API is quite disorganized and confusing. For example there is {{Polygon}} for creating an instance of polygon vertices and holes and {{Polygon2D}} for computing relations between points and polygons. There is also a {{PolygonPredicate}} and {{DistancePredicate}} in {{GeoUtils}} for computing point in polygon and point distance relations, respectively, and a {{GeoRelationUtils}} utility class which is no longer used for anything. This disorganization is due to the organic improvements of simple {{LatLonPoint}} indexing and search features and a little TLC is needed to clean up api to make it more approachable and easy to understand.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]