[jira] [Commented] (LUCENE-8765) OneDimensionBKDWriter valueCount validation didn't include leafCount

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-8765) OneDimensionBKDWriter valueCount validation didn't include leafCount

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820188#comment-16820188 ]

Adrien Grand commented on LUCENE-8765:
--------------------------------------

Good catch! This patch seems to have been created off an old master checkout, but it is still easy to apply. One minor thing I'd like to change is to use expectThrows in the test rather than a try/catch block if that works for you.

> OneDimensionBKDWriter valueCount validation didn't include leafCount
> --------------------------------------------------------------------
>
>                 Key: LUCENE-8765
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8765
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/other
>    Affects Versions: 7.5, master (9.0)
>            Reporter: ZhaoYang
>            Priority: Minor
>         Attachments: 0001-Fix-OneDimensionBKDWriter-valueCount-validation.patch
>
>
> {{[OneDimensionBKDWriter#add|https://github.com/jasonstack/lucene-solr/blob/branch_7_5/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java#L612]}} checks if {{valueCount}} exceeds predefined {{totalPointCount}}, but {{valueCount}} is only updated for every 1024({{DEFAULT_MAX_POINTS_IN_LEAF_NODE}}) points.
> We should include {{leafCount}} for validation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]