[jira] [Commented] (NUTCH-2419) Domain blacklist URL filter does not respect command-line override for file

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NUTCH-2419) Domain blacklist URL filter does not respect command-line override for file

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NUTCH-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160441#comment-16160441 ]

Sebastian Nagel commented on NUTCH-2419:
----------------------------------------

It sounds plausible that a property (independent whether from command-line or set in nutch-site.xml) overwrites the defaults defined in code resp. by the attribute/parameter "file" defined in the {{plugin.xml}}. I do not know what the idea was initially, however
# the [API docs|http://nutch.apache.org/apidocs/apidocs-1.13/org/apache/nutch/urlfilter/domainblacklist/DomainBlacklistURLFilter.html] explicitely states that
{quote}
the attribute "file" has higher precedence if defined.
{quote}
# this behavior is shared by many urlfilter-* and urlnormalizer-* plugins which suggests to change all of them in one turn
# shall the variable {{domainFile}} passed to the constructor still take precedence (afaics, it's used only for unit tests)?

> Domain blacklist URL filter does not respect command-line override for file
> ---------------------------------------------------------------------------
>
>                 Key: NUTCH-2419
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2419
>             Project: Nutch
>          Issue Type: Bug
>    Affects Versions: 1.13
>            Reporter: Markus Jelsma
>            Assignee: Markus Jelsma
>            Priority: Minor
>             Fix For: 1.14
>
>         Attachments: NUTCH-2419.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)