[jira] [Commented] (NUTCH-2574) Generator: hostCount >= maxCount comparison wrong

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NUTCH-2574) Generator: hostCount >= maxCount comparison wrong

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NUTCH-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510807#comment-16510807 ]

Hudson commented on NUTCH-2574:
-------------------------------

SUCCESS: Integrated in Jenkins build Nutch-trunk #3536 (See [https://builds.apache.org/job/Nutch-trunk/3536/])
NUTCH-2574 Generator: hostCount >= maxCount comparison wrong - ensure (snagel: [https://github.com/apache/nutch/commit/646932a71f5954fec2ef781939d4683b271837fe])
* (edit) src/java/org/apache/nutch/crawl/Generator.java
NUTCH-2574 Generator: hostCount >= maxCount comparison wrong - fix (snagel: [https://github.com/apache/nutch/commit/d3cd0dc738f5a5a538e82808e6490dd89bf55fad])
* (edit) src/test/org/apache/nutch/crawl/TestGenerator.java


> Generator: hostCount >= maxCount comparison wrong
> -------------------------------------------------
>
>                 Key: NUTCH-2574
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2574
>             Project: Nutch
>          Issue Type: Bug
>          Components: generator
>    Affects Versions: 1.13
>            Reporter: Michael Coffey
>            Assignee: Sebastian Nagel
>            Priority: Minor
>             Fix For: 1.15
>
>
> In the Generator.Selector.reduce function, there is a comparison of hostCount[1] to maxCount, to determine whether or not to push the current URL to the next segment. The purpose is to honor generate.max.count.
> Sebastian noticed that it should test if (hostCount[1] > maxCount) rather than ">=".  As it stands, the code sometimes puts one less url into a segment than it should.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)