[jira] [Commented] (SOLR-11054) Add SoftAutoCommitTest.testSoftAndHardCommitMaxDocs

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (SOLR-11054) Add SoftAutoCommitTest.testSoftAndHardCommitMaxDocs

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-11054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124387#comment-16124387 ]

Cao Manh Dat commented on SOLR-11054:
-------------------------------------

So in AutoCommitTest.testMaxDocs() we actually test for one more thing. All indexed docs are searchable, therefore my opinion for testSoftAndHardCommitMaxDocs() is we also should add this check. But sure, we can commit your patch first then adding necessary changes later.

> Add SoftAutoCommitTest.testSoftAndHardCommitMaxDocs
> ---------------------------------------------------
>
>                 Key: SOLR-11054
>                 URL: https://issues.apache.org/jira/browse/SOLR-11054
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public)
>            Reporter: Hoss Man
>         Attachments: SOLR-11054.patch, SOLR-11054.patch
>
>
> SoftAutoCommitTest should have a testSoftAndHardCommitMaxDocs that checks the maxDocs option for autocommit using the same monitor polling used by other existing SoftAutoCommitTest tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...