[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251614#comment-16251614 ]

David Smiley commented on SOLR-11380:
-------------------------------------

RE GenericSolrRequest: I think you may misunderstand what I'm getting at.  GSR had a getter & setter for a field.  You removed the getter from this class, letting it use a new default implementation at the SolrRequest level that returns null.  This is clearly broken; if someone uses this class, calling the setter, they expect the getter will return it!   RE your suggestion of a getter & setter for ContentWriter is good.

I think you should mark every public reference to a method referencing ContentStream as deprecated in SolrJ so that by 8.0 users know not to use it anymore.  To enhance visibility in the community of this fact, perhaps file as a separate issue.

BTW I looked at the viability of my 2nd bullet question on implementing RequestWriter.getContentWriter in terms of a getContentStreams but its impossible.  So that's some technical debt to be cleaned up in 8.0.

> SolrJ must stream docs to server instead of writing to a byte[] first
> ----------------------------------------------------------------------
>
>                 Key: SOLR-11380
>                 URL: https://issues.apache.org/jira/browse/SOLR-11380
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 7.2, master (8.0)
>
>         Attachments: SOLR-11380.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]