[jira] [Commented] (SOLR-11812) Remove backward compatibility of old LIR implementation in 8.0

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-11812) Remove backward compatibility of old LIR implementation in 8.0

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-11812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646445#comment-16646445 ]

Steve Rowe commented on SOLR-11812:
-----------------------------------

LIROnShardRestartTest is failing without a seed on master, and the first failing commit is {{a37a21397}} on this issue. E.g. from [https://builds.apache.org/job/Lucene-Solr-NightlyTests-master/1664/]:

{noformat}
Checking out Revision 971a0e3f4afddab4687642834037c52fef0c6758 (refs/remotes/origin/master)
[...]
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=LIROnShardRestartTest -Dtests.method=testAllReplicasInLIR -Dtests.seed=8C817C4A81BE13BB -Dtests.multiplier=2 -Dtests.nightly=true -Dtests.slow=true -Dtests.linedocsfile=/home/jenkins/jenkins-slave/workspace/Lucene-Solr-NightlyTests-master/test-data/enwiki.random.lines.txt -Dtests.locale=zh-SG -Dtests.timezone=America/Nassau -Dtests.asserts=true -Dtests.file.encoding=UTF-8
   [junit4] ERROR    119s J1 | LIROnShardRestartTest.testAllReplicasInLIR <<<
   [junit4]    > Throwable #1: java.lang.IllegalArgumentException: Path must not end with / character
   [junit4]    > at __randomizedtesting.SeedInfo.seed([8C817C4A81BE13BB:D619468CFF3E745C]:0)
   [junit4]    > at org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:58)
   [junit4]    > at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:1517)
   [junit4]    > at org.apache.solr.common.cloud.SolrZkClient.lambda$getChildren$4(SolrZkClient.java:329)
   [junit4]    > at org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation(ZkCmdExecutor.java:60)
   [junit4]    > at org.apache.solr.common.cloud.SolrZkClient.getChildren(SolrZkClient.java:329)
   [junit4]    > at org.apache.solr.cloud.LIROnShardRestartTest.testAllReplicasInLIR(LIROnShardRestartTest.java:168)
   [junit4]    > at java.lang.Thread.run(Thread.java:748)
[...]
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=LIROnShardRestartTest -Dtests.method=testSeveralReplicasInLIR -Dtests.seed=8C817C4A81BE13BB -Dtests.multiplier=2 -Dtests.nightly=true -Dtests.slow=true -Dtests.linedocsfile=/home/jenkins/jenkins-slave/workspace/Lucene-Solr-NightlyTests-master/test-data/enwiki.random.lines.txt -Dtests.locale=zh-SG -Dtests.timezone=America/Nassau -Dtests.asserts=true -Dtests.file.encoding=UTF-8
   [junit4] ERROR   0.27s J1 | LIROnShardRestartTest.testSeveralReplicasInLIR <<<
   [junit4]    > Throwable #1: org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException: Error from server at https://127.0.0.1:36816/solr: Cannot create collection severalReplicasInLIR. Value of maxShardsPerNode is 1, and the number of nodes currently live or live and part of your createNodeSet is 2. This allows a maximum of 2 to be created. Value of numShards is 1, value of nrtReplicas is 3, value of tlogReplicas is 0 and value of pullReplicas is 0. This requires 3 shards to be created (higher than the allowed number)
   [junit4]    > at __randomizedtesting.SeedInfo.seed([8C817C4A81BE13BB:ADBEB7EA1E45EE2]:0)
   [junit4]    > at org.apache.solr.client.solrj.impl.HttpSolrClient.executeMethod(HttpSolrClient.java:643)
   [junit4]    > at org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:255)
   [junit4]    > at org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:244)
   [junit4]    > at org.apache.solr.client.solrj.impl.LBHttpSolrClient.doRequest(LBHttpSolrClient.java:483)
   [junit4]    > at org.apache.solr.client.solrj.impl.LBHttpSolrClient.request(LBHttpSolrClient.java:413)
   [junit4]    > at org.apache.solr.client.solrj.impl.CloudSolrClient.sendRequest(CloudSolrClient.java:1107)
   [junit4]    > at org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:884)
   [junit4]    > at org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:817)
   [junit4]    > at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:194)
   [junit4]    > at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:211)
   [junit4]    > at org.apache.solr.cloud.LIROnShardRestartTest.testSeveralReplicasInLIR(LIROnShardRestartTest.java:190)
   [junit4]    > at java.lang.Thread.run(Thread.java:748)
{noformat}

> Remove backward compatibility of old LIR implementation in 8.0
> --------------------------------------------------------------
>
>                 Key: SOLR-11812
>                 URL: https://issues.apache.org/jira/browse/SOLR-11812
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public)
>            Reporter: Cao Manh Dat
>            Assignee: Cao Manh Dat
>            Priority: Blocker
>             Fix For: master (8.0)
>
>         Attachments: SOLR-11812.patch
>
>
> My plan is commit SOLR-11702 on the next 7.x release. We have to support both old and the new design so users can do rolling updates.
> This makes code base very complex, in 8.0 we do not have to support rolling updates, so this issue is created to remind us to remove all the old LIR implementation in 8.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]