[jira] [Commented] (SOLR-12199) TestReplicationHandler.doTestRepeater(): TEST_PORT interpolation failure: Server refused connection at: http://127.0.0.1:TEST_PORT/solr

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-12199) TestReplicationHandler.doTestRepeater(): TEST_PORT interpolation failure: Server refused connection at: http://127.0.0.1:TEST_PORT/solr

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428792#comment-16428792 ]

ASF subversion and git services commented on SOLR-12199:
--------------------------------------------------------

Commit 5c37b07a3d53e64c2f0cebd33eb7024d693d62f5 in lucene-solr's branch refs/heads/master from [~steve_rowe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5c37b07 ]

SOLR-12199: TestReplicationHandler.doTestRepeater(): TEST_PORT interpolation failure: Server refused connection at: <a href="http://127.0.0.1:TEST_PORT/solr">http://127.0.0.1:TEST_PORT/solr


> TestReplicationHandler.doTestRepeater(): TEST_PORT interpolation failure: Server refused connection at: <a href="http://127.0.0.1:TEST_PORT/solr">http://127.0.0.1:TEST_PORT/solr 
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-12199
>                 URL: https://issues.apache.org/jira/browse/SOLR-12199
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public)
>            Reporter: Steve Rowe
>            Assignee: Steve Rowe
>            Priority: Major
>             Fix For: 7.4
>
>         Attachments: SOLR-12199.patch
>
>
> From [https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-MacOSX/551/]:
> {noformat}
>    [junit4]   2> 750759 INFO  (TEST-TestReplicationHandler.doTestRepeater-seed#[7078A21248E0962E]) [    ] o.a.s.h.TestReplicationHandler Waited for 0ms and found 3 docs
>    [junit4]   2> 750760 INFO  (qtp351238853-8844) [    x:collection1] o.a.s.c.S.Request [collection1]  webapp=/solr path=/replication params={_trace=getDetails&qt=/replication&wt=javabin&version=2&command=details} status=0 QTime=1
>    [junit4]   2> 750761 INFO  (qtp351238853-8846) [    x:collection1] o.a.s.c.S.Request [collection1]  webapp=/solr path=/replication params={_trace=getDetails&qt=/replication&wt=javabin&version=2&command=details} status=0 QTime=0
>    [junit4]   2> 750769 WARN  (qtp738580099-8901) [    x:collection1] o.a.s.h.ReplicationHandler Exception while invoking 'details' method for replication on master
>    [junit4]   2> org.apache.solr.client.solrj.SolrServerException: Server refused connection at: <a href="http://127.0.0.1:TEST_PORT/solr">http://127.0.0.1:TEST_PORT/solr
>    [junit4]   2> at org.apache.solr.client.solrj.impl.HttpSolrClient.executeMethod(HttpSolrClient.java:650) ~[java/:?]
>    [junit4]   2> at org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:255) ~[java/:?]
>    [junit4]   2> at org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:244) ~[java/:?]
>    [junit4]   2> at org.apache.solr.client.solrj.SolrClient.request(SolrClient.java:1219) ~[java/:?]
>    [junit4]   2> at org.apache.solr.handler.IndexFetcher.getDetails(IndexFetcher.java:1852) ~[java/:?]
> {noformat}
> I looked at {{TestReplicationHandler}} Jenkins failure logs from the last couple days, and every single one has the same pattern: a WARN message from {{doTestRepeater()}} about failure to connect with a URL containing port {{TEST_PORT}} (rather than a numeric value).
> On the dev list Dawid Weiss [wrote|https://lists.apache.org/thread.html/b9606be4ae70e58b4be8c3438e92f69361d59b4de566ec707dda3f24@%3Cdev.lucene.apache.org%3E]:
> {quote}
> I see this in TestReplicationHandler:
> {code:java}
>  /**
>   * character copy of file using UTF-8. If port is non-null, will be
> substituted any time "TEST_PORT" is found.
>   */
>  private static void copyFile(File src, File dst, Integer port,
> boolean internalCompression) throws IOException {
>    BufferedReader in = new BufferedReader(new InputStreamReader(new
> FileInputStream(src), StandardCharsets.UTF_8));
>    Writer out = new OutputStreamWriter(new FileOutputStream(dst),
> StandardCharsets.UTF_8);
>    for (String line = in.readLine(); null != line; line = in.readLine()) {
>      if (null != port)
>        line = line.replace("TEST_PORT", port.toString());
> {code}
> So it seems port is allowed to be null and then won't be substituted.
> This looks like a bug in the test scaffolding: this situation
> shouldn't be allowed; if a port cannot be acquired the test should
> fail much sooner?
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]