[jira] [Commented] (SOLR-12361) Change _childDocuments to Map

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-12361) Change _childDocuments to Map

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496048#comment-16496048 ]

David Smiley commented on SOLR-12361:
-------------------------------------

[~caomanhdat] can you please review the changes to IgnoreLargeDocumentProcessorFactory that mosh changed in PR 385?  (note it includes more tests).  I have and it looks good though I admit I'm confused by this URP as to when exactly it's doing a "primitiveEstimate" vs doing a "fastEstimate" (that isn't necessarily primitive).  Two of the instanceof dispatches look similar (fastEstimate(obj) and inside the loop of fastEstimate(map ).  Hey BTW line 115 could be changed to loop on the SolrInputFields instead of the field names to avoid doing an internal hashmap lookup on all field names.

> Change _childDocuments to Map
> -----------------------------
>
>                 Key: SOLR-12361
>                 URL: https://issues.apache.org/jira/browse/SOLR-12361
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public)
>            Reporter: mosh
>            Priority: Major
>         Attachments: SOLR-12361.patch, SOLR-12361.patch
>
>          Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> During the discussion on SOLR-12298, there was a proposal to change _childDocuments in SolrDocumentBase to a Map, to incorporate the relationship between the parent and its child documents.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]