[jira] Commented: (SOLR-1316) Create autosuggest component

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-1316) Create autosuggest component

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889154#action_12889154 ]

Robert Muir commented on SOLR-1316:
-----------------------------------

Hi Andrzej, i have a concern about unicode support here:

in JaspellTernarySearchTrie.compareCharsAlphabetically there is some code like:
{code}
if (cCompare2 >= 65) {
     if (cCompare2 < 89) {
        cCompare = (2 * cCompare2) - 65;
      } else if (cCompare2 < 97) {
        cCompare = cCompare2 + 24;
      } else if (cCompare2 < 121) {
        cCompare = (2 * cCompare2) - 128;
      } else cCompare = cCompare2;
    } else cCompare = cCompare2;
...
{code}

Could we consider a more unicode-friendly approach, such as simply comparing Character.toLowerCase(cCompare2) with Character.toLowerCase(cRef) ?

> Create autosuggest component
> ----------------------------
>
>                 Key: SOLR-1316
>                 URL: https://issues.apache.org/jira/browse/SOLR-1316
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>    Affects Versions: 1.4
>            Reporter: Jason Rutherglen
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: Next
>
>         Attachments: SOLR-1316.patch, SOLR-1316.patch, SOLR-1316.patch, SOLR-1316.patch, SOLR-1316.patch, SOLR-1316.patch, SOLR-1316.patch, SOLR-1316.patch, suggest.patch, suggest.patch, suggest.patch, TST.zip
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Autosuggest is a common search function that can be integrated
> into Solr as a SearchComponent. Our first implementation will
> use the TernaryTree found in Lucene contrib.
> * Enable creation of the dictionary from the index or via Solr's
> RPC mechanism
> * What types of parameters and settings are desirable?
> * Hopefully in the future we can include user click through
> rates to boost those terms/phrases higher

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]