[jira] [Commented] (SOLR-13231) async CREATE collection request doesn't fail or cleanup when the request fails

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-13231) async CREATE collection request doesn't fail or cleanup when the request fails

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765459#comment-16765459 ]

Tomás Fernández Löbbe commented on SOLR-13231:
----------------------------------------------

The cleanup is already happening (added in SOLR-8983), it's just that we fail to detect the failure in the async case because of this (essentially, the code checks for the "failure" key, but that's never added, since what fails are the internal async requests, which are logged with the request ID as key). Once I included the failed internal requests inside the "failure" map, the same logic that cleans up for the sync case works for async.

> async CREATE collection request doesn't fail or cleanup when the request fails
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-13231
>                 URL: https://issues.apache.org/jira/browse/SOLR-13231
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public)
>            Reporter: Tomás Fernández Löbbe
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When a CREATE collection command is issued with an async ID, the request is marked as "completed" regardless of the output of the create. Also related, the ClusterState is not cleaned up in the same way as a in the sync request case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]