[jira] [Commented] (SOLR-4693) Create a collections API to delete/cleanup a Slice

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-4693) Create a collections API to delete/cleanup a Slice

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13695270#comment-13695270 ]

Shalin Shekhar Mangar commented on SOLR-4693:
---------------------------------------------

bq. We 'can' but I feel we shouldn't as shard deletion is specific to a Slice in a collection, the collection deletes all Slices. I think it'd be an overkill.

I was thinking of a method:
{code}
private void sliceCmd(ClusterState clusterState, ModifiableSolrParams params, String stateMatcher, Slice slice)
{code}
which can be refactored out of collectionCmd and used for delete shard as well.

bq. bq. We should fail with appropriate error message if there were nodes which could not be unloaded. Perhaps a separate "deletecore" call is appropriate here?
bq. Isn't this opposite of what you say in #3?

Well, no. Look at what delete collection does in OverseerCollectionProcessor. It sends a collectionCmd to unload cores and then to make sure that a deleted collection does not ever come back, it makes a call to Overseer to remove the collection from ZK. We can do the same thing (and introduce a delete slice in overseer) or we could track the hosts on which the core unload failed and call Overseer's deletecore api directly.
               

> Create a collections API to delete/cleanup a Slice
> --------------------------------------------------
>
>                 Key: SOLR-4693
>                 URL: https://issues.apache.org/jira/browse/SOLR-4693
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Anshum Gupta
>            Assignee: Shalin Shekhar Mangar
>         Attachments: SOLR-4693.patch, SOLR-4693.patch
>
>
> Have a collections API that cleans up a given shard.
> Among other places, this would be useful post the shard split call to manage the parent/original slice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]