[jira] [Commented] (SOLR-6280) Collapse QParser should give error for multiValued field

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-6280) Collapse QParser should give error for multiValued field

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614945#comment-16614945 ]

Munendra S N commented on SOLR-6280:
------------------------------------

 [^SOLR-6280.patch]
[~dsmiley]
This patch handles two cases
1. Fail when collapse field is multivalued
2. Don't wrap SolrException again in RunTimeException

Also, there are cases where IOException is the right kind of exception to use but it has been used. (Preferably SolrException). For now, I haven't touched that code. Should this case also be handled here??

> Collapse QParser should give error for multiValued field
> --------------------------------------------------------
>
>                 Key: SOLR-6280
>                 URL: https://issues.apache.org/jira/browse/SOLR-6280
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>            Reporter: David Smiley
>            Priority: Minor
>         Attachments: SOLR-6280.patch
>
>
> The Collapse QParser does give results if you collapse on a multi-valued field, but the document->value is somewhat arbitrarily chosen based on the internals of the FieldCache (FieldCacheImpl.SortedDocValuesCache).
> Note that the Grouping functionality accesses values via FieldType.getValueSource which is a layer of abstraction above that includes a multiValued error check.
> Collapse should throw an error here.
> p.s. easy to test with exampledocs collapsing on "cat"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]