[jira] [Commented] (SOLR-9509) Fix problems in shell scripts reported by "shellcheck"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-9509) Fix problems in shell scripts reported by "shellcheck"

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053583#comment-16053583 ]

Mikhail Khludnev commented on SOLR-9509:
----------------------------------------

I tried to include bin/solr in test by disabling the fist condition in {{TestSolrCLIRunExample.RunExampleExecutor.execute(CommandLine)}} L110, but it failed almost all tests. So, probably smokeRelease.py can do that out of the box.

> Fix problems in shell scripts reported by "shellcheck"
> ------------------------------------------------------
>
>                 Key: SOLR-9509
>                 URL: https://issues.apache.org/jira/browse/SOLR-9509
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public)
>          Components: scripts and tools
>            Reporter: Jan H√łydahl
>              Labels: newdev
>         Attachments: bin_solr_shellcheck.txt, shellcheck_solr_20160915.txt, shellcheck_solr_bin_bash_20160915.txt, shellcheck_solr_bin_sh_20160915.txt, shellcheck_solr_usr_bin_env_bash_20160915.txt, SOLR-9509.patch
>
>
> Running {{shellcheck}} on our shell scripts reveal various improvements we should consider.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]