[jira] [Commented] (TIKA-2825) Make interrupter in tika-batch's child process actually optional

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (TIKA-2825) Make interrupter in tika-batch's child process actually optional

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/TIKA-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758430#comment-16758430 ]

Hudson commented on TIKA-2825:

SUCCESS: Integrated in Jenkins build tika-branch-1x #161 (See [https://builds.apache.org/job/tika-branch-1x/161/])
TIKA-2825 (tallison: [https://github.com/apache/tika/commit/acdc4fcc6997a37872b7794dc24130366864e054])
* (edit) tika-eval/src/main/resources/tika-eval-profiler-config.xml
* (edit) tika-eval/src/test/java/org/apache/tika/eval/tokens/TokenCounterTest.java
* (edit) tika-batch/src/main/java/org/apache/tika/batch/BatchProcess.java
* (edit) tika-batch/src/main/java/org/apache/tika/batch/builders/BatchProcessBuilder.java
* (edit) tika-eval/src/main/resources/tika-eval-comparison-config.xml

> Make interrupter in tika-batch's child process actually optional
> ----------------------------------------------------------------
>                 Key: TIKA-2825
>                 URL: https://issues.apache.org/jira/browse/TIKA-2825
>             Project: Tika
>          Issue Type: Task
>          Components: tika-batch, tika-eval
>            Reporter: Tim Allison
>            Priority: Trivial
>             Fix For: 1.21
> tika-eval uses tika-batch, but it only uses the child batch process because if there's a failure there, something went seriously wrong, and there shouldn't be a restart.
> The problem is that the child process uses stdin as a potential interrupt from the parent process.  If the child is run by itself, it uses the system's stdin, which can cause problems w nohup:
> {noformat}
> Exception from STDIN in CommandlineInterrupter.
> java.io.IOException: Bad file descriptor
>         at java.io.FileInputStream.readBytes(Native Method)
>         at java.io.FileInputStream.read(FileInputStream.java:255)
>         at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
>         at java.io.BufferedInputStream.read(BufferedInputStream.java:265)
>         at org.apache.tika.batch.Interrupter.call(Interrupter.java:52)
> {noformat}
> Further, the comments suggest that the interrupter is optional, and so it should be. :D

This message was sent by Atlassian JIRA