[jira] Created: (LUCENE-1251) on disk full during close, FSIndexOutput fails to close descriptor

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-1251) on disk full during close, FSIndexOutput fails to close descriptor

JIRA jira@apache.org
on disk full during close, FSIndexOutput fails to close descriptor
------------------------------------------------------------------

                 Key: LUCENE-1251
                 URL: https://issues.apache.org/jira/browse/LUCENE-1251
             Project: Lucene - Java
          Issue Type: Bug
    Affects Versions: 2.3.1, 2.3, 2.2, 2.1, 2.0.0, 1.9
            Reporter: Michael McCandless
            Assignee: Michael McCandless
            Priority: Minor
             Fix For: 2.3.2, 2.4


The close method just does this:

{code}
      if (isOpen) {
        super.close();
        file.close();
        isOpen = false;
      }
{code}

But super.close = BufferedIndexOutput.close, which tries to flush its buffer.  If disk is full (or something else is wrong) then we hit an exception and don't actually close the descriptor.

I will put a try/finally in so we always close, taking care to preserve the original exception. I'll commit shortly & backport to 2.3.2

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-1251) on disk full during close, FSIndexOutput fails to close descriptor

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-1251.
----------------------------------------

    Resolution: Fixed

> on disk full during close, FSIndexOutput fails to close descriptor
> ------------------------------------------------------------------
>
>                 Key: LUCENE-1251
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1251
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.3.2, 2.4
>
>
> The close method just does this:
> {code}
>       if (isOpen) {
>         super.close();
>         file.close();
>         isOpen = false;
>       }
> {code}
> But super.close = BufferedIndexOutput.close, which tries to flush its buffer.  If disk is full (or something else is wrong) then we hit an exception and don't actually close the descriptor.
> I will put a try/finally in so we always close, taking care to preserve the original exception. I'll commit shortly & backport to 2.3.2

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]