[jira] Created: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
---------------------------------------------------------

                 Key: LUCENE-2652
                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
             Project: Lucene - Java
          Issue Type: Test
          Components: Tests
            Reporter: Simon Willnauer
             Fix For: 3.1, 4.0


As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.

Here are some options:
* select the local at random only run the test with a single local
* set the local via system property -Dtest.locale=en.EN
* run with the default locale only -Dtest.skiplocale=true
* one from the above but only if instrumented with clover (let common tests run all the locale)



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-2652:
--------------------------------

    Attachment: LUCENE-2652.patch

here's a patch to disable use of the runners.

really i think the two runners (LocalizedTestCase/MultiCodecTestCase) are obselete anyway,
you can run any junit test under any locale/codec, and we select locale, timezone, and codec
randomly by default.


> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-2652:
------------------------------------

    Attachment: LUCENE-2652.patch

{quote}
really i think the two runners (LocalizedTestCase/MultiCodecTestCase) are obselete anyway,
you can run any junit test under any locale/codec, and we select locale, timezone, and codec
randomly by default.
{quote}
Yeah I agree that we should fix that and get rid of them. I also think we should apply a quick fix to make builds on hudson pass again. Yet, you patch changes lots of files - the patch I attached is less intrusive and has the same effect.

Lets commit that and do a real fix within the next days. Thoughts?

> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12911039#action_12911039 ]

Robert Muir commented on LUCENE-2652:
-------------------------------------

bq. Yet, you patch changes lots of files

Right, but long term we should remove these runners anyway.
So maybe we should delete the RunWiths *and* delete the runner code.

These runners are obselete and weaker than our general test support itself:
* the MultiCodecRunner cannot set parameters for the codecs, but LuceneTestCase can do this
* The LocalizedRunner cannot set timezone (this runner is used by lots of tests), but LuceneTestCase can do this


> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12911040#action_12911040 ]

Simon Willnauer commented on LUCENE-2652:
-----------------------------------------

{quote}
Right, but long term we should remove these runners anyway.
So maybe we should delete the RunWiths and delete the runner code.
{quote}
I agree robert but I want to let other folk have a chance to comment on how to proceed (its weekend and some may have other things to do) but at the same time I don't want to let hudson fail again due to clover / Junit 4.

I'd commit the fix to trunk and 3.x and decide once others have commented, thoughts?
 

> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12911052#action_12911052 ]

Robert Muir commented on LUCENE-2652:
-------------------------------------

bq. I'd commit the fix to trunk and 3.x and decide once others have commented, thoughts?

+1, commit it so our clover works

> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer reassigned LUCENE-2652:
---------------------------------------

    Assignee: Simon Willnauer

> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12911058#action_12911058 ]

Simon Willnauer commented on LUCENE-2652:
-----------------------------------------

I committed the quick fix for now

* 3.x -- Committed revision 998503.
* trunk -- Committed revision 998507.

I will work on a new patch tomorrow.

simon

> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-2652:
------------------------------------

    Attachment: LUCENE-2652.patch

I added support for tests.locale=all && tests.codec=all while still utilizing the TestRunners we used before. With this patch we preserve all functionality we had before  - being able to run with all locale / codec types for those tests which have been marked with the corresponding runners. Should we commit that until we change to a single runner?

Yet, i think what we should ultimately do is remove the runners and add support to run all permutations like a test with all codecs, locale , timezone etc. I don't think that it makes lot of sense to do that for every test but maybe we want to offer the test to tell if it wants to run with all locale and / or all codec ....

maybe something like

{code}

enum TestProperty {
  Locale, Codec, Timezone

}

...

setTestProperties(TestProperty ... properties) {
  ...
}

{code}

> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912237#action_12912237 ]

Robert Muir commented on LUCENE-2652:
-------------------------------------

{quote}
I added support for tests.locale=all && tests.codec=all while still utilizing the TestRunners we used before. With this patch we preserve all functionality we had before - being able to run with all locale / codec types for those tests which have been marked with the corresponding runners. Should we commit that until we change to a single runner?
{quote}

Not sure, i think its a little confusing, because this 'all' only affects tests that use the runner.

I still think we should remove these runners completely. there is other ways to test all locales/codecs: for example by doing ant test -Dtestcase=foo -Dtests.iter=1000, as it should randomly hit them all anyway, same with codecs.

and this works for all test cases, not just those annotated with the runners.

> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir reassigned LUCENE-2652:
-----------------------------------

    Assignee: Robert Muir  (was: Simon Willnauer)

> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>            Assignee: Robert Muir
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922361#action_12922361 ]

Robert Muir commented on LUCENE-2652:
-------------------------------------

Rethinking: Now that all tests are Junit4 tests, this issue is obselete.

these runners don't properly setup the locale correctly: only in setUp+test method itself.

But our build system now with -Dtests.locale does it correctly, @beforeClass is consistent too.

I'll remove these runners from LuceneTestCase shortly.


> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>            Assignee: Robert Muir
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-2652:
--------------------------------

    Attachment: LUCENE-2652.patch

> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>            Assignee: Robert Muir
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch, LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922455#action_12922455 ]

Simon Willnauer commented on LUCENE-2652:
-----------------------------------------

bq. I'll remove these runners from LuceneTestCase shortly.
 +1 thanks for taking this issue!

> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>            Assignee: Robert Muir
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch, LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-2652.
---------------------------------

    Resolution: Fixed

Committed revision 1024219, 1024223 (3x)

> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>            Assignee: Robert Muir
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch, LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d] we should rethink the way how we execute testcases with different locals since glover reports appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the locale)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]