[jira] [Created] (LUCENE-3677) Remove old byte[] norms api from IndexReader

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (LUCENE-3677) Remove old byte[] norms api from IndexReader

JIRA jira@apache.org
Remove old byte[] norms api from IndexReader
--------------------------------------------

                 Key: LUCENE-3677
                 URL: https://issues.apache.org/jira/browse/LUCENE-3677
             Project: Lucene - Java
          Issue Type: Task
            Reporter: Robert Muir


Followup to LUCENE-3628.

We should remove this api and just use docvalues everywhere, to allow for norms of arbitrary size in the future (not just byte[])

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3677) Remove old byte[] norms api from IndexReader

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3677:
--------------------------------

    Attachment: LUCENE-3677.patch
   

> Remove old byte[] norms api from IndexReader
> --------------------------------------------
>
>                 Key: LUCENE-3677
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3677
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-3677.patch
>
>
> Followup to LUCENE-3628.
> We should remove this api and just use docvalues everywhere, to allow for norms of arbitrary size in the future (not just byte[])

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3677) Remove old byte[] norms api from IndexReader

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180582#comment-13180582 ]

Robert Muir commented on LUCENE-3677:
-------------------------------------

all tests pass ... one tweak i thought of: maybe now we should rename IR.normValues(String) to just IR.norms(String) ?
               

> Remove old byte[] norms api from IndexReader
> --------------------------------------------
>
>                 Key: LUCENE-3677
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3677
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-3677.patch
>
>
> Followup to LUCENE-3628.
> We should remove this api and just use docvalues everywhere, to allow for norms of arbitrary size in the future (not just byte[])

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

RE: [jira] [Commented] (LUCENE-3677) Remove old byte[] norms api from IndexReader

Lince Peter
PLEASE UNSUBSCRIBE ME

Thanks & Regards

Lince Peter
Websphere Commerce Developer
CrossView, Inc.
mobile: 514.212.3224
[hidden email]
www.inkedin.com/in/lincepeter
http://www.crossview.com
Follow CrossView on Twitter! twitter.com/CrossView_Inc

This message may contain confidential and/or privileged information. If you
are not the addressee or authorized to receive this for the addressee, you
must not use, copy, disclose, or take any action based on this message or
any information herein. If you have received this message in error, please
advise the sender immediately by reply e-mail and delete this message. Thank
you for your cooperation.


-----Original Message-----
From: Robert Muir (Commented) (JIRA) [mailto:[hidden email]]
Sent: January-05-12 12:33 PM
To: [hidden email]
Subject: [jira] [Commented] (LUCENE-3677) Remove old byte[] norms api from
IndexReader


    [
https://issues.apache.org/jira/browse/LUCENE-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180582#comment-13180582
]

Robert Muir commented on LUCENE-3677:
-------------------------------------

all tests pass ... one tweak i thought of: maybe now we should rename
IR.normValues(String) to just IR.norms(String) ?

> Remove old byte[] norms api from IndexReader
> --------------------------------------------
>
>                 Key: LUCENE-3677
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3677
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-3677.patch
>
>
> Followup to LUCENE-3628.
> We should remove this api and just use docvalues everywhere, to allow for
> norms of arbitrary size in the future (not just byte[])

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3677) Remove old byte[] norms api from IndexReader

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3677:
--------------------------------

    Attachment: LUCENE-3677.patch

updated patch with just a tweak to checkindex.

now no apis actually require that the codecs norms impl implements getArray. maybe someone wants a more compact/sparse datastructure for some reason (LUCENE-830)... if they want this, thats fine.

But all our similarities use getArray. I think thats a fair tradeoff... if you want to use some crazy datastructure, fine but you must use a custom sim, too.
               

> Remove old byte[] norms api from IndexReader
> --------------------------------------------
>
>                 Key: LUCENE-3677
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3677
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-3677.patch, LUCENE-3677.patch
>
>
> Followup to LUCENE-3628.
> We should remove this api and just use docvalues everywhere, to allow for norms of arbitrary size in the future (not just byte[])

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3677) Remove old byte[] norms api from IndexReader

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180666#comment-13180666 ]

Simon Willnauer commented on LUCENE-3677:
-----------------------------------------

AWESOME! :)

bq. now no apis actually require that the codecs norms impl implements getArray. maybe someone wants a more compact/sparse datastructure for some reason (LUCENE-830)... if they want this, thats fine.

+1
               

> Remove old byte[] norms api from IndexReader
> --------------------------------------------
>
>                 Key: LUCENE-3677
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3677
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-3677.patch, LUCENE-3677.patch
>
>
> Followup to LUCENE-3628.
> We should remove this api and just use docvalues everywhere, to allow for norms of arbitrary size in the future (not just byte[])

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3677) Remove old byte[] norms api from IndexReader

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180676#comment-13180676 ]

Robert Muir commented on LUCENE-3677:
-------------------------------------

I plan to commit this one shortly and open a followup issues to allow norms to be things other than byte[]
               

> Remove old byte[] norms api from IndexReader
> --------------------------------------------
>
>                 Key: LUCENE-3677
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3677
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-3677.patch, LUCENE-3677.patch
>
>
> Followup to LUCENE-3628.
> We should remove this api and just use docvalues everywhere, to allow for norms of arbitrary size in the future (not just byte[])

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3677) Remove old byte[] norms api from IndexReader

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180685#comment-13180685 ]

Michael McCandless commented on LUCENE-3677:
--------------------------------------------

+1
               

> Remove old byte[] norms api from IndexReader
> --------------------------------------------
>
>                 Key: LUCENE-3677
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3677
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-3677.patch, LUCENE-3677.patch
>
>
> Followup to LUCENE-3628.
> We should remove this api and just use docvalues everywhere, to allow for norms of arbitrary size in the future (not just byte[])

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (LUCENE-3677) Remove old byte[] norms api from IndexReader

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-3677.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0
   

> Remove old byte[] norms api from IndexReader
> --------------------------------------------
>
>                 Key: LUCENE-3677
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3677
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3677.patch, LUCENE-3677.patch
>
>
> Followup to LUCENE-3628.
> We should remove this api and just use docvalues everywhere, to allow for norms of arbitrary size in the future (not just byte[])

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]