Quantcast

[jira] [Created] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

classic Classic list List threaded Threaded
29 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Created] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
--------------------------------------------------------------------------------------------------------

                 Key: LUCENE-3808
                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
             Project: Lucene - Java
          Issue Type: Sub-task
          Components: general/test
            Reporter: Dawid Weiss
            Assignee: Dawid Weiss
            Priority: Minor
             Fix For: 4.0


Switch the runner to RandomizedRunner. Enforce the following:
- Random sharing will result in a failure/ exception.
- Thread leaks will result in a failure (add lingering if needed, but no ignores).
- Add a validator for @Test method overrides (no-no).
- Add a validator for static hook shadowing (no-no).
- Add a validator for testXXX without @Test annotation.
- Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211955#comment-13211955 ]

Robert Muir commented on LUCENE-3808:
-------------------------------------

{quote}
Add a validator for testXXX without @Test annotation.
{quote}

Can we not require @Test? I think it should be fine to use testXXX without @Test. @Test is useless.
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Switch the runner to RandomizedRunner. Enforce the following:
> - Random sharing will result in a failure/ exception.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - Add a validator for testXXX without @Test annotation.
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211960#comment-13211960 ]

Uwe Schindler commented on LUCENE-3808:
---------------------------------------

Dawid: Please let us name our tests like in JUnit3, our old test framework has a good test runner improvement for that, we don't like the verbosity on imports and this annotation.
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Switch the runner to RandomizedRunner. Enforce the following:
> - Random sharing will result in a failure/ exception.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - Add a validator for testXXX without @Test annotation.
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211963#comment-13211963 ]

Erik Hatcher commented on LUCENE-3808:
--------------------------------------

bq. Can we not require @Test? I think it should be fine to use testXXX without @Test. @Test is useless.

+100000

I was wondering if anyone would ever speak up about this.  @Test is ridiculous.   (so is @Override too, for that matter) - metadata is in the model implicitly.
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Switch the runner to RandomizedRunner. Enforce the following:
> - Random sharing will result in a failure/ exception.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - Add a validator for testXXX without @Test annotation.
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211966#comment-13211966 ]

Dawid Weiss commented on LUCENE-3808:
-------------------------------------

Ok, ok, ok... I will not enforce @Test, don't kill me.
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Switch the runner to RandomizedRunner. Enforce the following:
> - Random sharing will result in a failure/ exception.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - Add a validator for testXXX without @Test annotation.
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Updated] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss updated LUCENE-3808:
--------------------------------

    Description:
Switch the runner to RandomizedRunner. Enforce the following:
- Random sharing will result in a failure/ exception.
- Thread leaks will result in a failure (add lingering if needed, but no ignores).
- Add a validator for @Test method overrides (no-no).
- Add a validator for static hook shadowing (no-no).
- -Add a validator for testXXX without @Test annotation.-
- Modify custom execution groups in LTC to be real @Groups.

  was:
Switch the runner to RandomizedRunner. Enforce the following:
- Random sharing will result in a failure/ exception.
- Thread leaks will result in a failure (add lingering if needed, but no ignores).
- Add a validator for @Test method overrides (no-no).
- Add a validator for static hook shadowing (no-no).
- Add a validator for testXXX without @Test annotation.
- Modify custom execution groups in LTC to be real @Groups.

   

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Switch the runner to RandomizedRunner. Enforce the following:
> - Random sharing will result in a failure/ exception.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - -Add a validator for testXXX without @Test annotation.-
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211999#comment-13211999 ]

Uwe Schindler commented on LUCENE-3808:
---------------------------------------

:-)
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Switch the runner to RandomizedRunner. Enforce the following:
> - Random sharing will result in a failure/ exception.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - -Add a validator for testXXX without @Test annotation.-
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212001#comment-13212001 ]

Uwe Schindler commented on LUCENE-3808:
---------------------------------------

bq. I was wondering if anyone would ever speak up about this. @Test is ridiculous. (so is @Override too, for that matter) - metadata is in the model implicitly.

@Override is indeed not really different but makes sense when you refactor classes. The big PRO is: no import required as its in java.lang. Thats the most horrible thing on @Test
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Switch the runner to RandomizedRunner. Enforce the following:
> - Random sharing will result in a failure/ exception.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - -Add a validator for testXXX without @Test annotation.-
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212004#comment-13212004 ]

Robert Muir commented on LUCENE-3808:
-------------------------------------

{quote}
@Override is indeed not really different but makes sense when you refactor classes.
{quote}

Interfaces too :)
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Switch the runner to RandomizedRunner. Enforce the following:
> - Random sharing will result in a failure/ exception.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - -Add a validator for testXXX without @Test annotation.-
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212012#comment-13212012 ]

Dawid Weiss commented on LUCENE-3808:
-------------------------------------

I like @Override, I even wish it were an explicit keyword like in C# (although I tend to like Java's by-default virtual methods more than C#'s explicit virtuals).
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Switch the runner to RandomizedRunner. Enforce the following:
> - Random sharing will result in a failure/ exception.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - -Add a validator for testXXX without @Test annotation.-
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219016#comment-13219016 ]

Dawid Weiss commented on LUCENE-3808:
-------------------------------------

I've hacked a local branch where I substituted LuceneTestCaseRunner for RandomizedRunner. And boy, hell broke loose ;)

So... the biggest issue I'm facing is indeed with Random sharing across threads. One may argue that sharing a Random instance across threads (with data races) is in fact making it even more random, but this doesn't seem to be the direction consistent with the possibility of consistently re-running the tests given the same starting seed. I know it isn't possible to coordinate threads anyway but I would still like to have Random instances to return identical sequences from within a single thread's perspective.

After this lengthy introduction, here comes an example of Random sharing:
{noformat}
   > Caused by: java.lang.RuntimeException: java.lang.IllegalStateException: This Random was created for/by another thread (Thread[RandomizedRunner-SuiteThread-org.apache.lucene.search.TestSearcherManager-seed#[3F1A26A6DA253628],5,RandomizedRunner-SuiteThreadGroup-org.apache.lucene.search.TestSearcherManager]). Random instances must not be shared (acquire per-thread). Current thread: Thread[Thread-53,5,RandomizedRunner-SuiteThreadGroup-org.apache.lucene.search.TestSearcherManager]
   > at __randomizedtesting.SeedInfo.seed([3F1A26A6DA253628]:0)
   > at org.apache.lucene.index.ThreadedIndexingAndSearchingTestCase$1.run(ThreadedIndexingAndSearchingTestCase.java:307)
   > Caused by: java.lang.IllegalStateException: This Random was created for/by another thread (Thread[RandomizedRunner-SuiteThread-org.apache.lucene.search.TestSearcherManager-seed#[3F1A26A6DA253628],5,RandomizedRunner-SuiteThreadGroup-org.apache.lucene.search.TestSearcherManager]). Random instances must not be shared (acquire per-thread). Current thread: Thread[Thread-53,5,RandomizedRunner-SuiteThreadGroup-org.apache.lucene.search.TestSearcherManager]
   > at com.carrotsearch.randomizedtesting.RandomNoSetSeed.checkValid(RandomNoSetSeed.java:124)
   > at com.carrotsearch.randomizedtesting.RandomNoSetSeed.nextInt(RandomNoSetSeed.java:72)
   > at org.apache.lucene.util.LuceneTestCase.rarely(LuceneTestCase.java:938)
   > at org.apache.lucene.analysis.MockAnalyzer.maybePayload(MockAnalyzer.java:102)
   > at org.apache.lucene.analysis.MockAnalyzer.createComponents(MockAnalyzer.java:95)
   > at org.apache.lucene.analysis.Analyzer.tokenStream(Analyzer.java:83)
   > at org.apache.lucene.document.Field.tokenStream(Field.java:467)
   > at org.apache.lucene.index.DocInverterPerField.processFields(DocInverterPerField.java:86)
   > at org.apache.lucene.index.DocFieldProcessor.processDocument(DocFieldProcessor.java:287)
   > at org.apache.lucene.index.DocumentsWriterPerThread.updateDocument(DocumentsWriterPerThread.java:241)
   > at org.apache.lucene.index.DocumentsWriter.updateDocument(DocumentsWriter.java:376)
   > at org.apache.lucene.index.IndexWriter.updateDocument(IndexWriter.java:1533)
   > at org.apache.lucene.index.IndexWriter.updateDocument(IndexWriter.java:1505)
   > at org.apache.lucene.index.ThreadedIndexingAndSearchingTestCase.updateDocument(ThreadedIndexingAndSearchingTestCase.java:111)
   > at org.apache.lucene.index.ThreadedIndexingAndSearchingTestCase$1.run(ThreadedIndexingAndSearchingTestCase.java:259)
   > Caused by: com.carrotsearch.randomizedtesting.NotAnException: Original allocation stack for this Random.
   > at java.lang.Thread.getStackTrace(Thread.java:1479)
   > at com.carrotsearch.randomizedtesting.RandomNoSetSeed.<init>(RandomNoSetSeed.java:26)
   > at com.carrotsearch.randomizedtesting.Randomness.<init>(Randomness.java:20)
   > at com.carrotsearch.randomizedtesting.Randomness.<init>(Randomness.java:24)
   > at com.carrotsearch.randomizedtesting.RandomizedRunner$3.run(RandomizedRunner.java:531)
   > at com.carrotsearch.randomizedtesting.RandomizedRunner.runSuite(RandomizedRunner.java:551)
   > at com.carrotsearch.randomizedtesting.RandomizedRunner.access$3(RandomizedRunner.java:495)
   > at com.carrotsearch.randomizedtesting.RandomizedRunner$2.run(RandomizedRunner.java:472)
{noformat}

What's happening is that a Random is pushed to MockAnalyzer and then multiple threads access the same instance. I am investigating possible workarounds for this -- Random instances are in fact thread local in RandomizedRunner so it would be possible to just grab your own Random in places like MockAnalyzer, without passing a ready to use instance.

An ostrich solution is to dodge the issue and simply drop checking if a Random instance is shared or not, but it wouldn't be so much fun then, would it?
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Switch the runner to RandomizedRunner. Enforce the following:
> - Random sharing will result in a failure/ exception.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - -Add a validator for testXXX without @Test annotation.-
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219024#comment-13219024 ]

Dawid Weiss commented on LUCENE-3808:
-------------------------------------

I've found this in the code:
{noformat}
    private final Random r;
    public MockIndexWriter(Random r, Directory dir, IndexWriterConfig conf) throws IOException {
      super(dir, conf);
      // must make a private random since our methods are
      // called from different threads; else test failures may
      // not be reproducible from the original seed
      this.r = new Random(r.nextInt());
{noformat}
Ha! :)
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Switch the runner to RandomizedRunner. Enforce the following:
> - Random sharing will result in a failure/ exception.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - -Add a validator for testXXX without @Test annotation.-
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Updated] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss updated LUCENE-3808:
--------------------------------

    Description:
Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr

Switch the runner to RandomizedRunner. Enforce the following:
- (/) Random sharing will result in a failure/ exception.
- (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
- Thread leaks will result in a failure (add lingering if needed, but no ignores).
- Add a validator for @Test method overrides (no-no).
- Add a validator for static hook shadowing (no-no).
- Modify custom execution groups in LTC to be real @Groups.

  was:
Switch the runner to RandomizedRunner. Enforce the following:
- Random sharing will result in a failure/ exception.
- Thread leaks will result in a failure (add lingering if needed, but no ignores).
- Add a validator for @Test method overrides (no-no).
- Add a validator for static hook shadowing (no-no).
- -Add a validator for testXXX without @Test annotation.-
- Modify custom execution groups in LTC to be real @Groups.

   

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr
> Switch the runner to RandomizedRunner. Enforce the following:
> - (/) Random sharing will result in a failure/ exception.
> - (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219111#comment-13219111 ]

Michael McCandless commented on LUCENE-3808:
--------------------------------------------

bq. So... the biggest issue I'm facing is indeed with Random sharing across threads.

I think we should always (try to!) make a thread-private, consistently seed'd Random instance...

True, the scheduling of the threads by the JVM will always be a source of non-determinism, but we shouldn't make that worse.  And, for some bugs, having consistent thread-private Random will make the bug fully reproducible (ie if the bug isn't a thread scheduling issue).
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr
> Switch the runner to RandomizedRunner. Enforce the following:
> - (/) Random sharing will result in a failure/ exception.
> - (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219114#comment-13219114 ]

Dawid Weiss commented on LUCENE-3808:
-------------------------------------

I'm working on this on my github branch. This is a good test case for the runner itself.
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr
> Switch the runner to RandomizedRunner. Enforce the following:
> - (/) Random sharing will result in a failure/ exception.
> - (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Updated] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss updated LUCENE-3808:
--------------------------------

    Description:
Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr

Switch the runner to RandomizedRunner. Enforce the following:
- (/) Random sharing will result in a failure/ exception.
- (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
- (/) Make sure tests are executed with assertions enabled (at least for solr/lucene packages).
- Thread leaks will result in a failure (add lingering if needed, but no ignores).
- Add a validator for @Test method overrides (no-no).
- Add a validator for static hook shadowing (no-no).
- Modify custom execution groups in LTC to be real @Groups.

  was:
Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr

Switch the runner to RandomizedRunner. Enforce the following:
- (/) Random sharing will result in a failure/ exception.
- (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
- Thread leaks will result in a failure (add lingering if needed, but no ignores).
- Add a validator for @Test method overrides (no-no).
- Add a validator for static hook shadowing (no-no).
- Modify custom execution groups in LTC to be real @Groups.

   

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr
> Switch the runner to RandomizedRunner. Enforce the following:
> - (/) Random sharing will result in a failure/ exception.
> - (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
> - (/) Make sure tests are executed with assertions enabled (at least for solr/lucene packages).
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219120#comment-13219120 ]

Dawid Weiss commented on LUCENE-3808:
-------------------------------------

I've fixed all offending tests under lucene/
https://github.com/dweiss/lucene_solr/commit/1d9a7effd06cfc0b393b7e00b8b7f755bd967700

All tests pass with RandomizedRunner there and the output from tests that failed was an excellent source to quickly get at the offending place.

This looks very good to me so far. Solr and modules next.
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr
> Switch the runner to RandomizedRunner. Enforce the following:
> - (/) Random sharing will result in a failure/ exception.
> - (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
> - (/) Make sure tests are executed with assertions enabled (at least for solr/lucene packages).
> - Thread leaks will result in a failure (add lingering if needed, but no ignores).
> - Add a validator for @Test method overrides (no-no).
> - Add a validator for static hook shadowing (no-no).
> - Modify custom execution groups in LTC to be real @Groups.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Updated] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss updated LUCENE-3808:
--------------------------------

    Description:
Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr

Switch the runner to RandomizedRunner. Enforce the following:
- (/) Random sharing will result in a failure/ exception.
- (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
- (/) Make sure tests are executed with assertions enabled (at least for solr/lucene packages).
- (/) Add a validator for static hook shadowing (no-no).
- (/) Modify custom execution groups in LTC to be real @Groups.
- Thread leaks will result in a failure (add lingering if needed, but no ignores). [this is done, but disabled]
- Add a validator for @Test method overrides (check how many of these we already have first).


  was:
Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr

Switch the runner to RandomizedRunner. Enforce the following:
- (/) Random sharing will result in a failure/ exception.
- (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
- (/) Make sure tests are executed with assertions enabled (at least for solr/lucene packages).
- Thread leaks will result in a failure (add lingering if needed, but no ignores).
- Add a validator for @Test method overrides (no-no).
- Add a validator for static hook shadowing (no-no).
- Modify custom execution groups in LTC to be real @Groups.

   

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr
> Switch the runner to RandomizedRunner. Enforce the following:
> - (/) Random sharing will result in a failure/ exception.
> - (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
> - (/) Make sure tests are executed with assertions enabled (at least for solr/lucene packages).
> - (/) Add a validator for static hook shadowing (no-no).
> - (/) Modify custom execution groups in LTC to be real @Groups.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores). [this is done, but disabled]
> - Add a validator for @Test method overrides (check how many of these we already have first).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Updated] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss updated LUCENE-3808:
--------------------------------

    Description:
Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr

Switch the runner to RandomizedRunner. Enforce the following:
- (/) Random sharing will result in a failure/ exception.
- (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
- (/) Make sure tests are executed with assertions enabled (at least for solr/lucene packages).
- (/) Add a validator for static hook shadowing (no-no).
- (/) Modify custom execution groups in LTC to be real @Groups.
- Thread leaks will result in a failure (add lingering if needed, but no ignores). [this is done, but disabled]
- Add a validator for @Test method overrides (check how many of these we already have first).
- What to do with thread-shared Random instances copies in MockIndexWriter and MockAnalyzer?

  was:
Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr

Switch the runner to RandomizedRunner. Enforce the following:
- (/) Random sharing will result in a failure/ exception.
- (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
- (/) Make sure tests are executed with assertions enabled (at least for solr/lucene packages).
- (/) Add a validator for static hook shadowing (no-no).
- (/) Modify custom execution groups in LTC to be real @Groups.
- Thread leaks will result in a failure (add lingering if needed, but no ignores). [this is done, but disabled]
- Add a validator for @Test method overrides (check how many of these we already have first).


   

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr
> Switch the runner to RandomizedRunner. Enforce the following:
> - (/) Random sharing will result in a failure/ exception.
> - (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
> - (/) Make sure tests are executed with assertions enabled (at least for solr/lucene packages).
> - (/) Add a validator for static hook shadowing (no-no).
> - (/) Modify custom execution groups in LTC to be real @Groups.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores). [this is done, but disabled]
> - Add a validator for @Test method overrides (check how many of these we already have first).
> - What to do with thread-shared Random instances copies in MockIndexWriter and MockAnalyzer?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (LUCENE-3808) Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254054#comment-13254054 ]

Dawid Weiss commented on LUCENE-3808:
-------------------------------------

I'm planning to merge github branched code into trunk this weekend. It's been running in parallel for some time now on my build server and it seems to have the same failure coverage and at the same time is a start to clean up LuceneTestCase and associated test code.

I hope you'll also like the new infrastructure -- will elaborate about this a bit once merged.
               

> Switch LuceneTestCaseRunner to RandomizedRunner. Enforce Random sharing contracts. Enforce thread leaks.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3808
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3808
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> Dev. branch at: https://github.com/dweiss/lucene_solr/tree/rr
> Switch the runner to RandomizedRunner. Enforce the following:
> - (/) Random sharing will result in a failure/ exception.
> - (/) -Add a validator for testXXX without @Test annotation.- (custom test provider added).
> - (/) Make sure tests are executed with assertions enabled (at least for solr/lucene packages).
> - (/) Add a validator for static hook shadowing (no-no).
> - (/) Modify custom execution groups in LTC to be real @Groups.
> - Thread leaks will result in a failure (add lingering if needed, but no ignores). [this is done, but disabled]
> - Add a validator for @Test method overrides (check how many of these we already have first).
> - What to do with thread-shared Random instances copies in MockIndexWriter and MockAnalyzer?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

12
Loading...