[jira] [Created] (LUCENE-3985) Refactor support for thread leaks

classic Classic list List threaded Threaded
25 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
Refactor support for thread leaks
---------------------------------

                 Key: LUCENE-3985
                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
             Project: Lucene - Java
          Issue Type: Sub-task
          Components: general/test
            Reporter: Dawid Weiss
            Assignee: Dawid Weiss
            Priority: Minor
             Fix For: 4.0


This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss updated LUCENE-3985:
--------------------------------

    Issue Type: Improvement  (was: Sub-task)
        Parent:     (was: LUCENE-3784)
   

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425678#comment-13425678 ]

Dawid Weiss commented on LUCENE-3985:
-------------------------------------

I have a branch on which tests pass. There are some threads that I ignore in Solr because there is no way to shut them down cleanly. I'll provide a patch soon.
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss updated LUCENE-3985:
--------------------------------

    Attachment: LUCENE-3985.patch

A patch that adds refactored thread leak detection (at the suite level), improved reporting, suite timeouts and other whistles.

Check out TestWorstCaseTestBehavior and uncomment methods demonstrating these features if you'd like to see what it looks like.

Solr tests pass because I added this:
{code}
+    // THESE ARE LIKELY BUGS - these threads should be closed!
+    if (threadName.startsWith("Overseer-") ||
+        threadName.startsWith("aliveCheckExecutor-") ||
+        threadName.startsWith("concurrentUpdateScheduler-")) {
+      return true;
+    }
{code}

These should be fixed but I have too little Solr knowledge to do it myself. Also, one entire test suite is commented out -- FullSolrCloudTest. This one leaks threads that don't look safe to me.
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425781#comment-13425781 ]

Mark Miller commented on LUCENE-3985:
-------------------------------------

bq. This one leaks threads that don't look safe to me.

What kind of threads are you considering not safe?
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425827#comment-13425827 ]

Dawid Weiss commented on LUCENE-3985:
-------------------------------------

I'd say no threads should be left after a suite completes, really, but I understand the pattern of having a static executor to which tasks are dispatched. Shutting it down will be difficult because it's effectively a one-time initialization singleton. I consider this "safe" because these threads in general just wait idly for jobs. I cannot rule out that they are still processing something but checking this adds more overhead than necessary. We could shorten the expiration time on these executors and increase lingering beyond this expiration time so theoretically it's possible to wait for a clean state but I think it'll increase tests time to an unacceptable level (didn't check though).

That one particular test suite leaks threads that have stack traces reaching into solr though -- if you care to take a look at see what they are and if some kind of shutdown is missing, I'd appreciate.
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425874#comment-13425874 ]

Dawid Weiss commented on LUCENE-3985:
-------------------------------------

FullSolrCloudTest leaves the following:
{code}

68621 T11 ccr.ThreadLeakControl.checkThreadLeaks SEVERE 3 threads leaked from SUITE scope at org.apache.solr.cloud.FullSolrCloudTest:
           1) Thread[id=606, name=Thread-97, state=WAITING, group=Overseer state updater.]
                at java.lang.Object.wait(Native Method)
                at java.lang.Object.wait(Object.java:503)
                at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1345)
                at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:925)
                at org.apache.solr.common.cloud.SolrZkClient$7.execute(SolrZkClient.java:289)
                at org.apache.solr.common.cloud.SolrZkClient$7.execute(SolrZkClient.java:1)
                at org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation(ZkCmdExecutor.java:67)
                at org.apache.solr.common.cloud.SolrZkClient.getData(SolrZkClient.java:286)
                at org.apache.solr.cloud.Overseer$CloudStateUpdater.amILeader(Overseer.java:187)
                at org.apache.solr.cloud.Overseer$CloudStateUpdater.run(Overseer.java:113)
                at java.lang.Thread.run(Thread.java:722)
           2) Thread[id=600, name=TEST-FullSolrCloudTest.testDistribSearch-seed#[535509622737983D]-EventThread, state=WAITING, group=TGRP-FullSolrCloudTest]
                at sun.misc.Unsafe.park(Native Method)
                at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
                at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2043)
                at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
                at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
           3) Thread[id=599, name=TEST-FullSolrCloudTest.testDistribSearch-seed#[535509622737983D]-SendThread(127.0.0.1:57474), state=RUNNABLE, group=TGRP-FullSolrCloudTest]
                at sun.nio.ch.WindowsSelectorImpl$SubSelector.poll0(Native Method)
                at sun.nio.ch.WindowsSelectorImpl$SubSelector.poll(WindowsSelectorImpl.java:295)
                at sun.nio.ch.WindowsSelectorImpl$SubSelector.access$400(WindowsSelectorImpl.java:277)
                at sun.nio.ch.WindowsSelectorImpl.doSelect(WindowsSelectorImpl.java:158)
                at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:87)
                at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:98)
                at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1131)
{code}
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425879#comment-13425879 ]

Mark Miller commented on LUCENE-3985:
-------------------------------------

heh - unfortunately, for me, only sometimes does it fail with one thread - which is different than the 3 you see. I took a try at improving the case I can see.
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425892#comment-13425892 ]

Dawid Weiss commented on LUCENE-3985:
-------------------------------------

Yeah, it will vary -- the lingering time is 2 seconds but it's still not enough and I see some failures depending on the machine I use. My build server failed with this one, for example:
{code}
build 31-Jul-2012 15:01:23 [junit4:junit4] Suite: org.apache.solr.cloud.ZkCLITest
...
build 31-Jul-2012 15:01:23 [junit4:junit4]    > Throwable #1: com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from SUITE scope at org.apache.solr.cloud.ZkCLITest:
build 31-Jul-2012 15:01:23 [junit4:junit4]    >    1) Thread[id=20260, name=SessionTracker, state=TIMED_WAITING, group=TGRP-ZkCLITest]
build 31-Jul-2012 15:01:23 [junit4:junit4]    >         at java.lang.Object.wait(Native Method)
build 31-Jul-2012 15:01:23 [junit4:junit4]    >         at org.apache.zookeeper.server.SessionTrackerImpl.run(SessionTrackerImpl.java:145)
build 31-Jul-2012 15:01:23 [junit4:junit4]    > at __randomizedtesting.SeedInfo.seed([B90AA507E190F87]:0)
build 31-Jul-2012 15:01:23 [junit4:junit4]    >
{code}

We should try to nail these because they probably contribute to those thread limits that you've been commenting on. I also see some crazy thread IDs in logs like: T20000 which seems suspicious -- they should be reused after a while.

               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425900#comment-13425900 ]

Dawid Weiss commented on LUCENE-3985:
-------------------------------------

bq. they should be reused after a while.

Ok, from the JDK source code it seems they won't be.
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425933#comment-13425933 ]

Mark Miller commented on LUCENE-3985:
-------------------------------------

I saw another:

   2) Thread[id=13, name=SessionTracker, state=TIMED_WAITING, group=TGRP-FullSolrCloudTest]
        at java.lang.Object.wait(Native Method)
        at org.apache.zookeeper.server.SessionTrackerImpl.run(SessionTrackerImpl.java:145)
        at __randomizedtesting.SeedInfo.seed([657241244CA545BB]:0)

This, like I think some of the others, is stopping - it just has not stopped yet I guess. In this case, ZooKeeper tries to shutdown this thread simply by setting running to false - on its next loop it will notice and bail. ZooKeeper doesn't wait to make sure that has happened before returning from shutdown though.
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425946#comment-13425946 ]

Dawid Weiss commented on LUCENE-3985:
-------------------------------------

You're right. I'll probably add a hacky way to terminate these threads earlier instead of enforcing a long lingering time. Thanks Mark.
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss updated LUCENE-3985:
--------------------------------

    Attachment: LUCENE-3985.patch

Reiterated patch improving logging on suite timeouts among other things.

I've added @BadApples test group (enabled by default) which includes two zk tests that I just have no idea how to fix and that fail for me frequently (and with such a long log that I can't really tell what's a result of the test itself and what's an unexpected behavior). I needed this to run full solr/lucene tests to ensure other things were working.

Help to fix these two remaining tests would be great, I don't want to throw everything on Mark :)

This also brings a question if I should commit in a patch that will probably break all existing builds (those bad apples above). I think it's worth it, even at the price of temporarily ignoring those two tests.

               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch, LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss updated LUCENE-3985:
--------------------------------

    Attachment: LUCENE-3985.patch

Updated patch passing -Dtests.badapples to the spawned jvm (missed that).
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch, LUCENE-3985.patch, LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426802#comment-13426802 ]

Robert Muir commented on LUCENE-3985:
-------------------------------------

Did the "fail tests on uncaught exceptions from other threads" get factored into the new randomizedrunner?

               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch, LUCENE-3985.patch, LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426840#comment-13426840 ]

Dawid Weiss commented on LUCENE-3985:
-------------------------------------

It was actually there from the very beginning, only initially it was at the thread group level (not at the global level). Normally this wouldn't matter as most threads would inherit the test group but I changed it so that it's now on both and additionally verifies if the handles hasn't been changed along the way. ZooKeeper does substitute it so there is a hack aimed at eagerly initializing that part of ZooKeeper and restoring the handler.
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch, LUCENE-3985.patch, LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss updated LUCENE-3985:
--------------------------------

    Attachment: LUCENE-3985.patch

Build server bug feedback -- zookeeper init should be a class rule, not a test rule. Corrected.
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch, LUCENE-3985.patch, LUCENE-3985.patch, LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427168#comment-13427168 ]

Uwe Schindler commented on LUCENE-3985:
---------------------------------------

bq. You can add the signatures to the forbidden API list under jdk.txt (with comment) or a new file (but don't forget to place this new signature file in Lucene and Solr's filesets).

I think, to not complicate the filesets, we should use for this case simply jdk.txt and not a separate file (as all signatures refer to JDK. Otherwise we must rename jdk.txt to defaultCharsJdk.txt or whatever). Just place a comment in the introduction and add the signatures to jdk.txt. The other txt files in banned methods are more for other parts of lucene code-base (like test-only), or like commons-io, refer to a solr-only lib.
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch, LUCENE-3985.patch, LUCENE-3985.patch, LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427174#comment-13427174 ]

Dawid Weiss commented on LUCENE-3985:
-------------------------------------

I already added it to a patch in LUCENE-3985 and fixed most of the calls there. It is a separate file, I wanted it to be somewhat explicit.
               

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch, LUCENE-3985.patch, LUCENE-3985.patch, LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (LUCENE-3985) Refactor support for thread leaks

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427174#comment-13427174 ]

Dawid Weiss edited comment on LUCENE-3985 at 8/2/12 8:34 AM:
-------------------------------------------------------------

It is a separate file, I wanted it to be somewhat explicit. We can merge in later on, not a problem.
               
      was (Author: dweiss):
    I already added it to a patch in LUCENE-3985 and fixed most of the calls there. It is a separate file, I wanted it to be somewhat explicit.
                 

> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch, LUCENE-3985.patch, LUCENE-3985.patch, LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

12