[jira] [Created] (LUCENE-4043) Add scoring support for query time join

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (LUCENE-4043) Add scoring support for query time join

JIRA jira@apache.org
Martijn van Groningen created LUCENE-4043:
---------------------------------------------

             Summary: Add scoring support for query time join
                 Key: LUCENE-4043
                 URL: https://issues.apache.org/jira/browse/LUCENE-4043
             Project: Lucene - Java
          Issue Type: Improvement
          Components: modules/join
            Reporter: Martijn van Groningen


Have similar scoring for query time joining just like the index time block join (with the score mode).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-4043) Add scoring support for query time join

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn van Groningen updated LUCENE-4043:
------------------------------------------

    Attachment: LUCENE-4043.patch

Draft patch. Added ScoreMode as parameter to JoinUtil#createJoinQuery(...).

Maybe ScoreMode should be a public enum inside the join package.
               

> Add scoring support for query time join
> ---------------------------------------
>
>                 Key: LUCENE-4043
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4043
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/join
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-4043.patch
>
>
> Have similar scoring for query time joining just like the index time block join (with the score mode).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-4043) Add scoring support for query time join

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn van Groningen updated LUCENE-4043:
------------------------------------------

    Attachment: LUCENE-4043.patch

Updated patch.
* Started adding randomizing score mode in TestJoinUtil test class.
* Made ScoreMode a public enum in join package.
               

> Add scoring support for query time join
> ---------------------------------------
>
>                 Key: LUCENE-4043
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4043
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/join
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-4043.patch, LUCENE-4043.patch
>
>
> Have similar scoring for query time joining just like the index time block join (with the score mode).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-4043) Add scoring support for query time join

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn van Groningen updated LUCENE-4043:
------------------------------------------

    Attachment: LUCENE-4043.patch

Updated patch.
* Fixed random tests.
* Added support for explain.
* Added ScoreMode support for documents that relate to more than one document.

I think it is ready to be committed.
               

> Add scoring support for query time join
> ---------------------------------------
>
>                 Key: LUCENE-4043
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4043
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/join
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch
>
>
> Have similar scoring for query time joining just like the index time block join (with the score mode).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-4043) Add scoring support for query time join

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284417#comment-13284417 ]

Michael McCandless commented on LUCENE-4043:
--------------------------------------------

Patch looks great!

You don't need to use your own growFactor ... just call ArrayUtil.grow
directly (it already oversizes under the hood for you).

Maybe remove @throws IAE from createJoinQuery's javadocs?  (But, still
throw it... in case we add a new ScoreMode and forget to fix this
code, in the future).  Because today all ScoreMode enum values work...

Fix omitted to emitted in the comment on top of "class MVInnerScorer".

Probably javadocs should somewhere explain about the "first time doc
is emitted it gets that score"?

Maybe explain added RAM requirements when scores are tracked in the
javadocs?

Maybe rename TermsWithScoreCollector.MV.Avg.ordScores -> .scoreCounts
(and .scores -> .scoreSums?).

Can we put back the non-wildcard imports?

               

> Add scoring support for query time join
> ---------------------------------------
>
>                 Key: LUCENE-4043
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4043
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/join
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch
>
>
> Have similar scoring for query time joining just like the index time block join (with the score mode).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-4043) Add scoring support for query time join

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn van Groningen updated LUCENE-4043:
------------------------------------------

    Attachment: LUCENE-4043.patch

Thanks for reviewing Mike! I've updated the patch.

bq. You don't need to use your own growFactor ... just call ArrayUtil.grow directly (it already oversizes under the hood for you).
Sure. (I didn't release that the ArrayUtil#oversize() was doing this)

bq. Maybe remove @throws IAE from createJoinQuery's javadocs? (But, still throw it... in case we add a new ScoreMode and forget to fix this code, in the future). Because today all ScoreMode enum values work...
Makes sense. We design it not to throw the exception. If the exception is thrown, then it is a bug.

bq. Fix omitted to emitted in the comment on top of "class MVInnerScorer".
Done.

bq. Probably javadocs should somewhere explain about the "first time doc is emitted it gets that score"?
Done.
bq. Maybe explain added RAM requirements when scores are tracked in the javadocs?
Done


bq. Maybe rename TermsWithScoreCollector.MV.Avg.ordScores -> .scoreCounts (and .scores -> .scoreSums?).
Done.

bq. Can we put back the non-wildcard imports?
Done. (IDE was trying to be smart... I'll change my settings...)
               

> Add scoring support for query time join
> ---------------------------------------
>
>                 Key: LUCENE-4043
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4043
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/join
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch
>
>
> Have similar scoring for query time joining just like the index time block join (with the score mode).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-4043) Add scoring support for query time join

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284529#comment-13284529 ]

Michael McCandless commented on LUCENE-4043:
--------------------------------------------

I still see one omitted :)  Otherwise this looks great: +1 to commit!
               

> Add scoring support for query time join
> ---------------------------------------
>
>                 Key: LUCENE-4043
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4043
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/join
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch
>
>
> Have similar scoring for query time joining just like the index time block join (with the score mode).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-4043) Add scoring support for query time join

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284556#comment-13284556 ]

Martijn van Groningen commented on LUCENE-4043:
-----------------------------------------------

Oops... I see. I'll commit soon!
               

> Add scoring support for query time join
> ---------------------------------------
>
>                 Key: LUCENE-4043
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4043
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/join
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch
>
>
> Have similar scoring for query time joining just like the index time block join (with the score mode).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-4043) Add scoring support for query time join

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn van Groningen updated LUCENE-4043:
------------------------------------------

    Fix Version/s: 4.0
   

> Add scoring support for query time join
> ---------------------------------------
>
>                 Key: LUCENE-4043
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4043
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/join
>            Reporter: Martijn van Groningen
>             Fix For: 4.0
>
>         Attachments: LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch
>
>
> Have similar scoring for query time joining just like the index time block join (with the score mode).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (LUCENE-4043) Add scoring support for query time join

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn van Groningen resolved LUCENE-4043.
-------------------------------------------

    Resolution: Fixed

Committed to trunk and branch4x.
               

> Add scoring support for query time join
> ---------------------------------------
>
>                 Key: LUCENE-4043
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4043
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/join
>            Reporter: Martijn van Groningen
>             Fix For: 4.0
>
>         Attachments: LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch
>
>
> Have similar scoring for query time joining just like the index time block join (with the score mode).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]