[jira] [Created] (LUCENE-4088) unindexed (stored-only) fields prevent future indexing of offsets

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (LUCENE-4088) unindexed (stored-only) fields prevent future indexing of offsets

JIRA jira@apache.org
Robert Muir created LUCENE-4088:
-----------------------------------

             Summary: unindexed (stored-only) fields prevent future indexing of offsets
                 Key: LUCENE-4088
                 URL: https://issues.apache.org/jira/browse/LUCENE-4088
             Project: Lucene - Java
          Issue Type: Bug
          Components: core/index
            Reporter: Robert Muir
             Fix For: 4.0


this is because we bogusly set FieldInfo.indexOptions to DOCS_AND_FREQS_AND_POSITIONS if the field is stored-only.

I don't think we should do that: the indexOptions should be null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-4088) unindexed (stored-only) fields prevent future indexing of offsets

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-4088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-4088:
--------------------------------

    Attachment: LUCENE-4088.patch

not a patch, just a testcase
               

> unindexed (stored-only) fields prevent future indexing of offsets
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4088
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4088
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-4088.patch
>
>
> this is because we bogusly set FieldInfo.indexOptions to DOCS_AND_FREQS_AND_POSITIONS if the field is stored-only.
> I don't think we should do that: the indexOptions should be null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-4088) unindexed (stored-only) fields prevent future indexing of offsets

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-4088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-4088:
--------------------------------

    Attachment: LUCENE-4088.patch

here's a stab at a fix. needs review: some scary stuff for sure.
               

> unindexed (stored-only) fields prevent future indexing of offsets
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4088
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4088
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-4088.patch, LUCENE-4088.patch
>
>
> this is because we bogusly set FieldInfo.indexOptions to DOCS_AND_FREQS_AND_POSITIONS if the field is stored-only.
> I don't think we should do that: the indexOptions should be null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-4088) unindexed (stored-only) fields prevent future indexing of offsets

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285185#comment-13285185 ]

Michael McCandless commented on LUCENE-4088:
--------------------------------------------

Patch looks good!  I love how FI.indexOptions are now null when field isn't indexed...
               

> unindexed (stored-only) fields prevent future indexing of offsets
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4088
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4088
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-4088.patch, LUCENE-4088.patch
>
>
> this is because we bogusly set FieldInfo.indexOptions to DOCS_AND_FREQS_AND_POSITIONS if the field is stored-only.
> I don't think we should do that: the indexOptions should be null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-4088) unindexed (stored-only) fields prevent future indexing of offsets

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-4088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-4088:
--------------------------------

    Attachment: LUCENE-4088.patch

same patch but with cosmetic fixes: the writeFreq/writeProx etc in FreqProxTermsWriter was imo confusing, especially as in flush its assigned to readFreq/readProx etc. I think these are clearer as hasFreq/hasProx.

I think this one is ready to commit
               

> unindexed (stored-only) fields prevent future indexing of offsets
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4088
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4088
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-4088.patch, LUCENE-4088.patch, LUCENE-4088.patch
>
>
> this is because we bogusly set FieldInfo.indexOptions to DOCS_AND_FREQS_AND_POSITIONS if the field is stored-only.
> I don't think we should do that: the indexOptions should be null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-4088) unindexed (stored-only) fields prevent future indexing of offsets

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285218#comment-13285218 ]

Michael McCandless commented on LUCENE-4088:
--------------------------------------------

+1, much better!
               

> unindexed (stored-only) fields prevent future indexing of offsets
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4088
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4088
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-4088.patch, LUCENE-4088.patch, LUCENE-4088.patch
>
>
> this is because we bogusly set FieldInfo.indexOptions to DOCS_AND_FREQS_AND_POSITIONS if the field is stored-only.
> I don't think we should do that: the indexOptions should be null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (LUCENE-4088) unindexed (stored-only) fields prevent future indexing of offsets

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-4088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-4088.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0
   

> unindexed (stored-only) fields prevent future indexing of offsets
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4088
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4088
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Robert Muir
>             Fix For: 4.0, 5.0
>
>         Attachments: LUCENE-4088.patch, LUCENE-4088.patch, LUCENE-4088.patch
>
>
> this is because we bogusly set FieldInfo.indexOptions to DOCS_AND_FREQS_AND_POSITIONS if the field is stored-only.
> I don't think we should do that: the indexOptions should be null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]