[jira] [Created] (LUCENE-4301) re-enable test timeout, but factor in nightly, multiplier, clover

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (LUCENE-4301) re-enable test timeout, but factor in nightly, multiplier, clover

JIRA jira@apache.org
Robert Muir created LUCENE-4301:
-----------------------------------

             Summary: re-enable test timeout, but factor in nightly, multiplier, clover
                 Key: LUCENE-4301
                 URL: https://issues.apache.org/jira/browse/LUCENE-4301
             Project: Lucene - Core
          Issue Type: Task
          Components: general/test
            Reporter: Robert Muir


Having a test timeout is great (for things like test hangs), but its going to cause a lot of failed builds until we factor in the various flags that can cause tests to run longer, or enable longer-running tests.

Its hard to say what the limits should be since jenkins history is pretty limited at the moment (only 2 nightly runs history available)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-4301) re-enable test timeout, but factor in nightly, multiplier, clover

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432969#comment-13432969 ]

Dawid Weiss commented on LUCENE-4301:
-------------------------------------

Let's take the maximum we know of and re-enable. Timeouts are meant to end hung tests that nobody looks at (jenkins). Even two hours per suite is fine as long as it is terminated at some point.
               

> re-enable test timeout, but factor in nightly, multiplier, clover
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4301
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4301
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/test
>            Reporter: Robert Muir
>
> Having a test timeout is great (for things like test hangs), but its going to cause a lot of failed builds until we factor in the various flags that can cause tests to run longer, or enable longer-running tests.
> Its hard to say what the limits should be since jenkins history is pretty limited at the moment (only 2 nightly runs history available)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-4301) re-enable test timeout, but factor in nightly, multiplier, clover

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432975#comment-13432975 ]

Dawid Weiss commented on LUCENE-4301:
-------------------------------------

I should probably add that there is no way to calculate the timeout value from the code because the decisions take place before the test code is started. It could be a system property override but then you'd have to set it properly based on your jenkins configuration, etc.

I'll re-enable for max. suite time = 2 hours? Alternatively override @TimeoutSuite on a particular test class that you know lasts longer than that.
               

> re-enable test timeout, but factor in nightly, multiplier, clover
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4301
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4301
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/test
>            Reporter: Robert Muir
>
> Having a test timeout is great (for things like test hangs), but its going to cause a lot of failed builds until we factor in the various flags that can cause tests to run longer, or enable longer-running tests.
> Its hard to say what the limits should be since jenkins history is pretty limited at the moment (only 2 nightly runs history available)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-4301) re-enable test timeout, but factor in nightly, multiplier, clover

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433054#comment-13433054 ]

Robert Muir commented on LUCENE-4301:
-------------------------------------

ok, 2 hours sounds good. and Test2BTerms should have integer.max_value :)
               

> re-enable test timeout, but factor in nightly, multiplier, clover
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4301
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4301
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/test
>            Reporter: Robert Muir
>
> Having a test timeout is great (for things like test hangs), but its going to cause a lot of failed builds until we factor in the various flags that can cause tests to run longer, or enable longer-running tests.
> Its hard to say what the limits should be since jenkins history is pretty limited at the moment (only 2 nightly runs history available)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-4301) re-enable test timeout, but factor in nightly, multiplier, clover

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433056#comment-13433056 ]

Dawid Weiss commented on LUCENE-4301:
-------------------------------------

Uh, really?! Damn. :) How long does it take? If it takes > 1 day I don't think it's a good test, really :)
               

> re-enable test timeout, but factor in nightly, multiplier, clover
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4301
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4301
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/test
>            Reporter: Robert Muir
>
> Having a test timeout is great (for things like test hangs), but its going to cause a lot of failed builds until we factor in the various flags that can cause tests to run longer, or enable longer-running tests.
> Its hard to say what the limits should be since jenkins history is pretty limited at the moment (only 2 nightly runs history available)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-4301) re-enable test timeout, but factor in nightly, multiplier, clover

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433078#comment-13433078 ]

Uwe Schindler commented on LUCENE-4301:
---------------------------------------

The problem with this test its that it must create an index with > 2 billion terms...

With some similar problems regarding overflow of document numbers, I used a trick in another test:

{code}
IndexReader small = ...
IndexReader[] arr1 = new IndexReader[count];
Arrays.fill(arr1, small);
MultiReader intermediate = new MulitiReader(arr1);
IndexReader[] arr2 = new IndexReader[count];
Arrays.fill(arr2, intermediate);
MultiReader huge = new MulitiReader(arr2);
{code}

Producing a composite reader with count * count * small.maxDoc() docs, but spending almost no RAM. Maybe we can do something similar here (wrapping this huge synthetic reader with SlowMultiReaderWrapper)?

               

> re-enable test timeout, but factor in nightly, multiplier, clover
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4301
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4301
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/test
>            Reporter: Robert Muir
>
> Having a test timeout is great (for things like test hangs), but its going to cause a lot of failed builds until we factor in the various flags that can cause tests to run longer, or enable longer-running tests.
> Its hard to say what the limits should be since jenkins history is pretty limited at the moment (only 2 nightly runs history available)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (LUCENE-4301) re-enable test timeout, but factor in nightly, multiplier, clover

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433078#comment-13433078 ]

Uwe Schindler edited comment on LUCENE-4301 at 8/13/12 10:50 PM:
-----------------------------------------------------------------

The problem with this test its that it must create an index with > 2 billion terms...

With some similar problems regarding overflow of document numbers, I used a trick in another test:

{code}
IndexReader small = ...
IndexReader[] arr1 = new IndexReader[count];
Arrays.fill(arr1, small);
MultiReader intermediate = new MultiReader(arr1);
IndexReader[] arr2 = new IndexReader[count];
Arrays.fill(arr2, intermediate);
MultiReader huge = new MultiReader(arr2);
{code}

Producing a composite reader with count * count * small.maxDoc() docs, but spending almost no RAM. Maybe we can do something similar here (wrapping this huge synthetic reader with SlowMultiReaderWrapper)?

               
      was (Author: thetaphi):
    The problem with this test its that it must create an index with > 2 billion terms...

With some similar problems regarding overflow of document numbers, I used a trick in another test:

{code}
IndexReader small = ...
IndexReader[] arr1 = new IndexReader[count];
Arrays.fill(arr1, small);
MultiReader intermediate = new MulitiReader(arr1);
IndexReader[] arr2 = new IndexReader[count];
Arrays.fill(arr2, intermediate);
MultiReader huge = new MulitiReader(arr2);
{code}

Producing a composite reader with count * count * small.maxDoc() docs, but spending almost no RAM. Maybe we can do something similar here (wrapping this huge synthetic reader with SlowMultiReaderWrapper)?

                 

> re-enable test timeout, but factor in nightly, multiplier, clover
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4301
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4301
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/test
>            Reporter: Robert Muir
>
> Having a test timeout is great (for things like test hangs), but its going to cause a lot of failed builds until we factor in the various flags that can cause tests to run longer, or enable longer-running tests.
> Its hard to say what the limits should be since jenkins history is pretty limited at the moment (only 2 nightly runs history available)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-4301) re-enable test timeout, but factor in nightly, multiplier, clover

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433095#comment-13433095 ]

Robert Muir commented on LUCENE-4301:
-------------------------------------

This test really needs 2 billion unique terms.
               

> re-enable test timeout, but factor in nightly, multiplier, clover
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4301
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4301
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/test
>            Reporter: Robert Muir
>
> Having a test timeout is great (for things like test hangs), but its going to cause a lot of failed builds until we factor in the various flags that can cause tests to run longer, or enable longer-running tests.
> Its hard to say what the limits should be since jenkins history is pretty limited at the moment (only 2 nightly runs history available)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-4301) re-enable test timeout, but factor in nightly, multiplier, clover

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss updated LUCENE-4301:
--------------------------------

    Attachment: evil.jpg

:)
               

> re-enable test timeout, but factor in nightly, multiplier, clover
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4301
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4301
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/test
>            Reporter: Robert Muir
>         Attachments: evil.jpg
>
>
> Having a test timeout is great (for things like test hangs), but its going to cause a lot of failed builds until we factor in the various flags that can cause tests to run longer, or enable longer-running tests.
> Its hard to say what the limits should be since jenkins history is pretty limited at the moment (only 2 nightly runs history available)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-4301) re-enable test timeout, but factor in nightly, multiplier, clover

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433107#comment-13433107 ]

Robert Muir commented on LUCENE-4301:
-------------------------------------

hehehe. But uwe's trick might speed up Test2BPostings a bit, if we are careful.

it only cares about 2B term/doc pairs in a segment, so we could build a reader
tree like this from one real segment and forceMerge it: maybe it would speed it up some.
               

> re-enable test timeout, but factor in nightly, multiplier, clover
> -----------------------------------------------------------------
>
>                 Key: LUCENE-4301
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4301
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/test
>            Reporter: Robert Muir
>         Attachments: evil.jpg
>
>
> Having a test timeout is great (for things like test hangs), but its going to cause a lot of failed builds until we factor in the various flags that can cause tests to run longer, or enable longer-running tests.
> Its hard to say what the limits should be since jenkins history is pretty limited at the moment (only 2 nightly runs history available)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]