[jira] Created: (LUCENE-714) Use a System.arraycopy more than a for

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-714) Use a System.arraycopy more than a for

JIRA jira@apache.org
Use a System.arraycopy more than a for
--------------------------------------

                 Key: LUCENE-714
                 URL: http://issues.apache.org/jira/browse/LUCENE-714
             Project: Lucene - Java
          Issue Type: Improvement
            Reporter: Nicolas Lalevée
         Attachments: DocumentWriter.patch

In org.apache.lucene.index.DocumentWriter. The patch will explain by itself. I didn't make any performance test, but I think it is obvious that it will be faster.
All tests passed.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-714) Use a System.arraycopy more than a for

JIRA jira@apache.org
     [ http://issues.apache.org/jira/browse/LUCENE-714?page=all ]

Nicolas Lalevée updated LUCENE-714:
-----------------------------------

    Attachment: DocumentWriter.patch

> Use a System.arraycopy more than a for
> --------------------------------------
>
>                 Key: LUCENE-714
>                 URL: http://issues.apache.org/jira/browse/LUCENE-714
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Nicolas Lalevée
>         Attachments: DocumentWriter.patch
>
>
> In org.apache.lucene.index.DocumentWriter. The patch will explain by itself. I didn't make any performance test, but I think it is obvious that it will be faster.
> All tests passed.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-714) Use a System.arraycopy more than a for

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org
    [ http://issues.apache.org/jira/browse/LUCENE-714?page=comments#action_12450680 ]
           
Nicolas Lalevée commented on LUCENE-714:
----------------------------------------

About the priority of the issue, I didn't want to set it to "Major", I just forget to set it correctly.

> Use a System.arraycopy more than a for
> --------------------------------------
>
>                 Key: LUCENE-714
>                 URL: http://issues.apache.org/jira/browse/LUCENE-714
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Nicolas Lalevée
>         Attachments: DocumentWriter.patch
>
>
> In org.apache.lucene.index.DocumentWriter. The patch will explain by itself. I didn't make any performance test, but I think it is obvious that it will be faster.
> All tests passed.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-714) Use a System.arraycopy more than a for

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org
    [ http://issues.apache.org/jira/browse/LUCENE-714?page=comments#action_12450704 ]
           
Michael McCandless commented on LUCENE-714:
-------------------------------------------

Thanks for the patch!

OK, it looks like you're replacing two cases in DocumentWriter.java where we are manually copying arrays with for loops, with calls to System.arraycopy instead.  This patch applies cleanly & the unit tests pass.  I will commit this.



> Use a System.arraycopy more than a for
> --------------------------------------
>
>                 Key: LUCENE-714
>                 URL: http://issues.apache.org/jira/browse/LUCENE-714
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Nicolas Lalevée
>         Attachments: DocumentWriter.patch
>
>
> In org.apache.lucene.index.DocumentWriter. The patch will explain by itself. I didn't make any performance test, but I think it is obvious that it will be faster.
> All tests passed.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-714) Use a System.arraycopy more than a for

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org
     [ http://issues.apache.org/jira/browse/LUCENE-714?page=all ]

Michael McCandless updated LUCENE-714:
--------------------------------------

    Priority: Minor  (was: Major)

> Use a System.arraycopy more than a for
> --------------------------------------
>
>                 Key: LUCENE-714
>                 URL: http://issues.apache.org/jira/browse/LUCENE-714
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Nicolas Lalevée
>            Priority: Minor
>         Attachments: DocumentWriter.patch
>
>
> In org.apache.lucene.index.DocumentWriter. The patch will explain by itself. I didn't make any performance test, but I think it is obvious that it will be faster.
> All tests passed.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-714) Use a System.arraycopy more than a for

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org
     [ http://issues.apache.org/jira/browse/LUCENE-714?page=all ]

Michael McCandless updated LUCENE-714:
--------------------------------------

    Lucene Fields: [New, Patch Available]  (was: [New])

> Use a System.arraycopy more than a for
> --------------------------------------
>
>                 Key: LUCENE-714
>                 URL: http://issues.apache.org/jira/browse/LUCENE-714
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Nicolas Lalevée
>            Priority: Minor
>         Attachments: DocumentWriter.patch
>
>
> In org.apache.lucene.index.DocumentWriter. The patch will explain by itself. I didn't make any performance test, but I think it is obvious that it will be faster.
> All tests passed.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-714) Use a System.arraycopy more than a for

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org
     [ http://issues.apache.org/jira/browse/LUCENE-714?page=all ]

Michael McCandless resolved LUCENE-714.
---------------------------------------

    Fix Version/s: 2.1
       Resolution: Fixed

Committed!  Thanks Nicolas -- keep the patches coming!

> Use a System.arraycopy more than a for
> --------------------------------------
>
>                 Key: LUCENE-714
>                 URL: http://issues.apache.org/jira/browse/LUCENE-714
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Nicolas Lalevée
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: DocumentWriter.patch
>
>
> In org.apache.lucene.index.DocumentWriter. The patch will explain by itself. I didn't make any performance test, but I think it is obvious that it will be faster.
> All tests passed.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]