[jira] Created: (LUCENE-745) Make inspection of BooleanQuery more efficient

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-745) Make inspection of BooleanQuery more efficient

JIRA jira@apache.org
Make inspection of BooleanQuery more efficient
----------------------------------------------

                 Key: LUCENE-745
                 URL: http://issues.apache.org/jira/browse/LUCENE-745
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Search
            Reporter: Yonik Seeley
            Priority: Minor


Just attempting to inspect a BooleanQuery allocates two new arrays.  This could be cheaper.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-745) Make inspection of BooleanQuery more efficient

JIRA jira@apache.org
     [ http://issues.apache.org/jira/browse/LUCENE-745?page=all ]

Yonik Seeley updated LUCENE-745:
--------------------------------

    Attachment: BooleanQuery.patch

Changes:
 - Vector changed to ArrayList for efficiency to remove unneeded synchronization
 - added clauses() method to return the List
 - changed getClauses() to pre-allocate the correct size, removing one allocation


> Make inspection of BooleanQuery more efficient
> ----------------------------------------------
>
>                 Key: LUCENE-745
>                 URL: http://issues.apache.org/jira/browse/LUCENE-745
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Yonik Seeley
>            Priority: Minor
>         Attachments: BooleanQuery.patch
>
>
> Just attempting to inspect a BooleanQuery allocates two new arrays.  This could be cheaper.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-745) Make inspection of BooleanQuery more efficient

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org
    [ http://issues.apache.org/jira/browse/LUCENE-745?page=comments#action_12457838 ]
           
Kevin Oliver commented on LUCENE-745:
-------------------------------------

This should also be considered along with LUCENE-711, which sizes some of the other Vectors more appropriately.

> Make inspection of BooleanQuery more efficient
> ----------------------------------------------
>
>                 Key: LUCENE-745
>                 URL: http://issues.apache.org/jira/browse/LUCENE-745
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Yonik Seeley
>            Priority: Minor
>         Attachments: BooleanQuery.patch
>
>
> Just attempting to inspect a BooleanQuery allocates two new arrays.  This could be cheaper.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-745) Make inspection of BooleanQuery more efficient

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley resolved LUCENE-745.
---------------------------------

    Resolution: Fixed

Closing... this patch has already been committed.

> Make inspection of BooleanQuery more efficient
> ----------------------------------------------
>
>                 Key: LUCENE-745
>                 URL: https://issues.apache.org/jira/browse/LUCENE-745
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Yonik Seeley
>            Priority: Minor
>         Attachments: BooleanQuery.patch
>
>
> Just attempting to inspect a BooleanQuery allocates two new arrays.  This could be cheaper.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]