[jira] Created: (NUTCH-469) changes to geoPosition plugin to make it work on nutch 0.9

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (NUTCH-469) changes to geoPosition plugin to make it work on nutch 0.9

JIRA jira@apache.org
changes to geoPosition plugin to make it work on nutch 0.9
----------------------------------------------------------

                 Key: NUTCH-469
                 URL: https://issues.apache.org/jira/browse/NUTCH-469
             Project: Nutch
          Issue Type: Improvement
          Components: indexer, searcher
    Affects Versions: 0.9.0
            Reporter: Mike Schwartz
             Fix For: 0.7.3


I have modified the geoPosition plugin (http://wiki.apache.org/nutch/GeoPosition) code to work with nutch 0.9.  (The code was built originally using nutch 0.7.)  I'd like to contribute my changes back to the nutch project.  I already communicated with the code's author (Matthias Jaekle), and he agrees with my mods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (NUTCH-469) changes to geoPosition plugin to make it work on nutch 0.9

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NUTCH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Schwartz updated NUTCH-469:
--------------------------------

    Attachment: geoPosition0.6_cdiff.zip

I've attached the contenxt diff from geoPosition 0.5 that I'm calling geoPosition 0.6, which makes it work with nutch 0.9.

> changes to geoPosition plugin to make it work on nutch 0.9
> ----------------------------------------------------------
>
>                 Key: NUTCH-469
>                 URL: https://issues.apache.org/jira/browse/NUTCH-469
>             Project: Nutch
>          Issue Type: Improvement
>          Components: indexer, searcher
>    Affects Versions: 0.9.0
>            Reporter: Mike Schwartz
>             Fix For: 0.7.3
>
>         Attachments: geoPosition0.6_cdiff.zip
>
>
> I have modified the geoPosition plugin (http://wiki.apache.org/nutch/GeoPosition) code to work with nutch 0.9.  (The code was built originally using nutch 0.7.)  I'd like to contribute my changes back to the nutch project.  I already communicated with the code's author (Matthias Jaekle), and he agrees with my mods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (NUTCH-469) changes to geoPosition plugin to make it work on nutch 0.9

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NUTCH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Jaekle updated NUTCH-469:
----------------------------------

    Attachment: geoPosition-0.5.tgz

Please find attached the old plugin version for nutch 0.7. Togehter with the patch of Mike the plugin should run under nutch 0.9.

> changes to geoPosition plugin to make it work on nutch 0.9
> ----------------------------------------------------------
>
>                 Key: NUTCH-469
>                 URL: https://issues.apache.org/jira/browse/NUTCH-469
>             Project: Nutch
>          Issue Type: Improvement
>          Components: indexer, searcher
>    Affects Versions: 0.9.0
>            Reporter: Mike Schwartz
>             Fix For: 0.7.3
>
>         Attachments: geoPosition-0.5.tgz, geoPosition0.6_cdiff.zip
>
>
> I have modified the geoPosition plugin (http://wiki.apache.org/nutch/GeoPosition) code to work with nutch 0.9.  (The code was built originally using nutch 0.7.)  I'd like to contribute my changes back to the nutch project.  I already communicated with the code's author (Matthias Jaekle), and he agrees with my mods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Updated: (NUTCH-469) changes to geoPosition plugin to make it work on nutch 0.9

mfschwartz
In reply to this post by JIRA jira@apache.org
Hi,

It's been a couple of weeks since I uploaded my patches to make the
GeoPosition plugin work on nutch 0.9.  I'm wondering whether there's
something I can do to help the process along to get these changes
accepted - or whether there was a problem with the code?

Thanks,
  - Mike Schwartz

At 01:15 PM 4/24/2007, Mike Schwartz (JIRA) wrote:

>      [
> https://issues.apache.org/jira/browse/NUTCH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel 
> ]
>
>Mike Schwartz updated NUTCH-469:
>--------------------------------
>
>     Attachment: geoPosition0.6_cdiff.zip
>
>I've attached the contenxt diff from geoPosition 0.5 that I'm
>calling geoPosition 0.6, which makes it work with nutch 0.9.
>
> > changes to geoPosition plugin to make it work on nutch 0.9
> > ----------------------------------------------------------
> >
> >                 Key: NUTCH-469
> >                 URL: https://issues.apache.org/jira/browse/NUTCH-469
> >             Project: Nutch
> >          Issue Type: Improvement
> >          Components: indexer, searcher
> >    Affects Versions: 0.9.0
> >            Reporter: Mike Schwartz
> >             Fix For: 0.7.3
> >
> >         Attachments: geoPosition0.6_cdiff.zip
> >
> >
> > I have modified the geoPosition plugin
> (http://wiki.apache.org/nutch/GeoPosition) code to work with nutch
> 0.9.  (The code was built originally using nutch 0.7.)  I'd like to
> contribute my changes back to the nutch project.  I already
> communicated with the code's author (Matthias Jaekle), and he
> agrees with my mods.
>
>--
>This message is automatically generated by JIRA.
>-
>You can reply to this email to add a comment to the issue online.
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (NUTCH-469) changes to geoPosition plugin to make it work on nutch 0.9

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NUTCH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sami Siren updated NUTCH-469:
-----------------------------

    Attachment: NUTCH-469-2007-05-09.txt.gz

tnahks for putting this together, I briefly checked through the .gz and patch

-please use diffs against trunk in future, they're more easy to check (svn diff > file)
-there is no junit tests at all, however there is tiny piece of test code in class GeoIndexingFilter, atleast this code could perhaps be moved to a junit test class
-i replaced System.out.prints with logging statements
-i changed some formatting
-would it make sense to move the zip folder from conf to under plugins src/java and change the load mechanism to use (context) class loader as i believe they are quite static piece of information once generated?

I am attaching the patch is it is now

> changes to geoPosition plugin to make it work on nutch 0.9
> ----------------------------------------------------------
>
>                 Key: NUTCH-469
>                 URL: https://issues.apache.org/jira/browse/NUTCH-469
>             Project: Nutch
>          Issue Type: Improvement
>          Components: indexer, searcher
>    Affects Versions: 0.9.0
>            Reporter: Mike Schwartz
>             Fix For: 0.7.3
>
>         Attachments: geoPosition-0.5.tgz, geoPosition0.6_cdiff.zip, NUTCH-469-2007-05-09.txt.gz
>
>
> I have modified the geoPosition plugin (http://wiki.apache.org/nutch/GeoPosition) code to work with nutch 0.9.  (The code was built originally using nutch 0.7.)  I'd like to contribute my changes back to the nutch project.  I already communicated with the code's author (Matthias Jaekle), and he agrees with my mods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (NUTCH-469) changes to geoPosition plugin to make it work on nutch 0.9

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NUTCH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sami Siren updated NUTCH-469:
-----------------------------

    Fix Version/s:     (was: 0.7.3)
                   1.0.0

> changes to geoPosition plugin to make it work on nutch 0.9
> ----------------------------------------------------------
>
>                 Key: NUTCH-469
>                 URL: https://issues.apache.org/jira/browse/NUTCH-469
>             Project: Nutch
>          Issue Type: Improvement
>          Components: indexer, searcher
>    Affects Versions: 0.9.0
>            Reporter: Mike Schwartz
>             Fix For: 1.0.0
>
>         Attachments: geoPosition-0.5.tgz, geoPosition0.6_cdiff.zip, NUTCH-469-2007-05-09.txt.gz
>
>
> I have modified the geoPosition plugin (http://wiki.apache.org/nutch/GeoPosition) code to work with nutch 0.9.  (The code was built originally using nutch 0.7.)  I'd like to contribute my changes back to the nutch project.  I already communicated with the code's author (Matthias Jaekle), and he agrees with my mods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Updated: (NUTCH-469) changes to geoPosition plugin to make it work on nutch 0.9

mfschwartz
In reply to this post by JIRA jira@apache.org
Sami,

Thanks for your response.  In answer to the points you made:

 >please use diffs against trunk in future, they're more easy to check
 >(svn diff > file)

will do

 >there is no junit tests at all, however there is tiny piece of test code
 >in class GeoIndexingFilter, atleast this code could perhaps be moved to
 >a junit test class
 >
 >i replaced System.out.prints with logging statements

both of these issues predate my changes - I didn't write the original
code, I just updated it to get it to work on nutch 0.9.

 >i changed some formatting
 >
 >would it make sense to move the zip folder from conf to under plugins
 >src/java and change the load mechanism to use (context) class loader as
 >i believe they are quite static piece of information once generated?

I agree, but again it wasn't my code so if you're looking for the
original author's inputs we should ask him.  I'll forward this
exchange to him (I don't think he subscribes to nutch-dev)

thanks
  - Mike



At 10:39 AM 5/9/2007, you wrote:

>      [
> https://issues.apache.org/jira/browse/NUTCH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel 
> ]
>
>Sami Siren updated NUTCH-469:
>-----------------------------
>
>     Attachment: NUTCH-469-2007-05-09.txt.gz
>
>tnahks for putting this together, I briefly checked through the .gz and patch
>
>-please use diffs against trunk in future, they're more easy to
>check (svn diff > file)
>-there is no junit tests at all, however there is tiny piece of test
>code in class GeoIndexingFilter, atleast this code could perhaps be
>moved to a junit test class
>-i replaced System.out.prints with logging statements
>-i changed some formatting
>-would it make sense to move the zip folder from conf to under
>plugins src/java and change the load mechanism to use (context)
>class loader as i believe they are quite static piece of information
>once generated?
>
>I am attaching the patch is it is now
>
> > changes to geoPosition plugin to make it work on nutch 0.9
> > ----------------------------------------------------------
> >
> >                 Key: NUTCH-469
> >                 URL: https://issues.apache.org/jira/browse/NUTCH-469
> >             Project: Nutch
> >          Issue Type: Improvement
> >          Components: indexer, searcher
> >    Affects Versions: 0.9.0
> >            Reporter: Mike Schwartz
> >             Fix For: 0.7.3
> >
> >         Attachments: geoPosition-0.5.tgz,
> geoPosition0.6_cdiff.zip, NUTCH-469-2007-05-09.txt.gz
> >
> >
> > I have modified the geoPosition plugin
> (http://wiki.apache.org/nutch/GeoPosition) code to work with nutch
> 0.9.  (The code was built originally using nutch 0.7.)  I'd like to
> contribute my changes back to the nutch project.  I already
> communicated with the code's author (Matthias Jaekle), and he
> agrees with my mods.
>
>--
>This message is automatically generated by JIRA.
>-
>You can reply to this email to add a comment to the issue online.
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NUTCH-469) changes to geoPosition plugin to make it work on nutch 0.9

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NUTCH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671127#action_12671127 ]

Andrzej Bialecki  commented on NUTCH-469:
-----------------------------------------

This issue was originally scheduled for 1.0, but it's still incomplete. Either we complete it within a week, or we should move it to 1.1.

> changes to geoPosition plugin to make it work on nutch 0.9
> ----------------------------------------------------------
>
>                 Key: NUTCH-469
>                 URL: https://issues.apache.org/jira/browse/NUTCH-469
>             Project: Nutch
>          Issue Type: Improvement
>          Components: indexer, searcher
>    Affects Versions: 0.9.0
>            Reporter: Mike Schwartz
>             Fix For: 1.0.0
>
>         Attachments: geoPosition-0.5.tgz, geoPosition0.6_cdiff.zip, NUTCH-469-2007-05-09.txt.gz
>
>
> I have modified the geoPosition plugin (http://wiki.apache.org/nutch/GeoPosition) code to work with nutch 0.9.  (The code was built originally using nutch 0.7.)  I'd like to contribute my changes back to the nutch project.  I already communicated with the code's author (Matthias Jaekle), and he agrees with my mods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (NUTCH-469) changes to geoPosition plugin to make it work on nutch 0.9

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NUTCH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sami Siren updated NUTCH-469:
-----------------------------

    Fix Version/s:     (was: 1.0.0)
                   1.1

pushing this to 1.1

> changes to geoPosition plugin to make it work on nutch 0.9
> ----------------------------------------------------------
>
>                 Key: NUTCH-469
>                 URL: https://issues.apache.org/jira/browse/NUTCH-469
>             Project: Nutch
>          Issue Type: Improvement
>          Components: indexer, searcher
>    Affects Versions: 0.9.0
>            Reporter: Mike Schwartz
>             Fix For: 1.1
>
>         Attachments: geoPosition-0.5.tgz, geoPosition0.6_cdiff.zip, NUTCH-469-2007-05-09.txt.gz
>
>
> I have modified the geoPosition plugin (http://wiki.apache.org/nutch/GeoPosition) code to work with nutch 0.9.  (The code was built originally using nutch 0.7.)  I'd like to contribute my changes back to the nutch project.  I already communicated with the code's author (Matthias Jaekle), and he agrees with my mods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (NUTCH-469) changes to geoPosition plugin to make it work on nutch 0.9

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NUTCH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julien Nioche updated NUTCH-469:
--------------------------------

    Fix Version/s:     (was: 1.1)

There has not been any changes to this issue since February 09 and it won't be included in 1.1
Marking it as 'fix version : unknown'

> changes to geoPosition plugin to make it work on nutch 0.9
> ----------------------------------------------------------
>
>                 Key: NUTCH-469
>                 URL: https://issues.apache.org/jira/browse/NUTCH-469
>             Project: Nutch
>          Issue Type: Improvement
>          Components: indexer, searcher
>    Affects Versions: 0.9.0
>            Reporter: Mike Schwartz
>         Attachments: geoPosition-0.5.tgz, geoPosition0.6_cdiff.zip, NUTCH-469-2007-05-09.txt.gz
>
>
> I have modified the geoPosition plugin (http://wiki.apache.org/nutch/GeoPosition) code to work with nutch 0.9.  (The code was built originally using nutch 0.7.)  I'd like to contribute my changes back to the nutch project.  I already communicated with the code's author (Matthias Jaekle), and he agrees with my mods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.