[jira] Created: (NUTCH-538) Delete unused classes under o.a.n.util

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (NUTCH-538) Delete unused classes under o.a.n.util

JIRA jira@apache.org
Delete unused classes under o.a.n.util
--------------------------------------

                 Key: NUTCH-538
                 URL: https://issues.apache.org/jira/browse/NUTCH-538
             Project: Nutch
          Issue Type: Improvement
            Reporter: Doğacan Güney
            Priority: Trivial
             Fix For: 1.0.0
         Attachments: delete_unused.patch

ThreadPool and FibonacciHeap is not used by anything else in nutch source so, IMHO, there is no point keeping them. Java 5 has really nice alternatives to ThreadPool under java.util.concurrent. I don't know if FibonacciHeap is faster than java's priority queue but we don't make huge priority queues anyway so even if it is faster it is probably not noticable.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (NUTCH-538) Delete unused classes under o.a.n.util

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NUTCH-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doğacan Güney updated NUTCH-538:
--------------------------------

    Attachment: delete_unused.patch

Trivial patch to delete ThreadPool and FibonacciHeap.

> Delete unused classes under o.a.n.util
> --------------------------------------
>
>                 Key: NUTCH-538
>                 URL: https://issues.apache.org/jira/browse/NUTCH-538
>             Project: Nutch
>          Issue Type: Improvement
>            Reporter: Doğacan Güney
>            Priority: Trivial
>             Fix For: 1.0.0
>
>         Attachments: delete_unused.patch
>
>
> ThreadPool and FibonacciHeap is not used by anything else in nutch source so, IMHO, there is no point keeping them. Java 5 has really nice alternatives to ThreadPool under java.util.concurrent. I don't know if FibonacciHeap is faster than java's priority queue but we don't make huge priority queues anyway so even if it is faster it is probably not noticable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (NUTCH-538) Delete unused classes under o.a.n.util

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NUTCH-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doğacan Güney resolved NUTCH-538.
---------------------------------

    Resolution: Fixed
      Assignee: Doğacan Güney

Committed in rev. 593261.

> Delete unused classes under o.a.n.util
> --------------------------------------
>
>                 Key: NUTCH-538
>                 URL: https://issues.apache.org/jira/browse/NUTCH-538
>             Project: Nutch
>          Issue Type: Improvement
>            Reporter: Doğacan Güney
>            Assignee: Doğacan Güney
>            Priority: Trivial
>             Fix For: 1.0.0
>
>         Attachments: delete_unused.patch
>
>
> ThreadPool and FibonacciHeap is not used by anything else in nutch source so, IMHO, there is no point keeping them. Java 5 has really nice alternatives to ThreadPool under java.util.concurrent. I don't know if FibonacciHeap is faster than java's priority queue but we don't make huge priority queues anyway so even if it is faster it is probably not noticable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (NUTCH-538) Delete unused classes under o.a.n.util

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NUTCH-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doğacan Güney closed NUTCH-538.
-------------------------------


> Delete unused classes under o.a.n.util
> --------------------------------------
>
>                 Key: NUTCH-538
>                 URL: https://issues.apache.org/jira/browse/NUTCH-538
>             Project: Nutch
>          Issue Type: Improvement
>            Reporter: Doğacan Güney
>            Assignee: Doğacan Güney
>            Priority: Trivial
>             Fix For: 1.0.0
>
>         Attachments: delete_unused.patch
>
>
> ThreadPool and FibonacciHeap is not used by anything else in nutch source so, IMHO, there is no point keeping them. Java 5 has really nice alternatives to ThreadPool under java.util.concurrent. I don't know if FibonacciHeap is faster than java's priority queue but we don't make huge priority queues anyway so even if it is faster it is probably not noticable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NUTCH-538) Delete unused classes under o.a.n.util

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NUTCH-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541234 ]

Hudson commented on NUTCH-538:
------------------------------

Integrated in Nutch-Nightly #261 (See [http://lucene.zones.apache.org:8080/hudson/job/Nutch-Nightly/261/])

> Delete unused classes under o.a.n.util
> --------------------------------------
>
>                 Key: NUTCH-538
>                 URL: https://issues.apache.org/jira/browse/NUTCH-538
>             Project: Nutch
>          Issue Type: Improvement
>            Reporter: Doğacan Güney
>            Assignee: Doğacan Güney
>            Priority: Trivial
>             Fix For: 1.0.0
>
>         Attachments: delete_unused.patch
>
>
> ThreadPool and FibonacciHeap is not used by anything else in nutch source so, IMHO, there is no point keeping them. Java 5 has really nice alternatives to ThreadPool under java.util.concurrent. I don't know if FibonacciHeap is faster than java's priority queue but we don't make huge priority queues anyway so even if it is faster it is probably not noticable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NUTCH-538) Delete unused classes under o.a.n.util

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NUTCH-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541510 ]

Hudson commented on NUTCH-538:
------------------------------

Integrated in Nutch-Nightly #262 (See [http://lucene.zones.apache.org:8080/hudson/job/Nutch-Nightly/262/])

> Delete unused classes under o.a.n.util
> --------------------------------------
>
>                 Key: NUTCH-538
>                 URL: https://issues.apache.org/jira/browse/NUTCH-538
>             Project: Nutch
>          Issue Type: Improvement
>            Reporter: Doğacan Güney
>            Assignee: Doğacan Güney
>            Priority: Trivial
>             Fix For: 1.0.0
>
>         Attachments: delete_unused.patch
>
>
> ThreadPool and FibonacciHeap is not used by anything else in nutch source so, IMHO, there is no point keeping them. Java 5 has really nice alternatives to ThreadPool under java.util.concurrent. I don't know if FibonacciHeap is faster than java's priority queue but we don't make huge priority queues anyway so even if it is faster it is probably not noticable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.