[jira] Created: (SOLR-1845) terms component response format uses list instead of map

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-1845) terms component response format uses list instead of map

JIRA jira@apache.org
terms component response format uses list instead of map
--------------------------------------------------------

                 Key: SOLR-1845
                 URL: https://issues.apache.org/jira/browse/SOLR-1845
             Project: Solr
          Issue Type: Bug
    Affects Versions: 1.4
            Reporter: Yonik Seeley
             Fix For: 3.1


The terms component uses a named list instead of simple ordered map for it's top-level data structure.
Access by name is more important, so it should be a map.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-1845) terms component response format uses list instead of map

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849685#action_12849685 ]

Yonik Seeley commented on SOLR-1845:
------------------------------------

Remember to check the JSON output for new request handlers!

We currently have this:
{code}
 "terms":[
  "features",[
{code}

But it should be this:
{code}
 "terms": {
  "features" : [
{code}


> terms component response format uses list instead of map
> --------------------------------------------------------
>
>                 Key: SOLR-1845
>                 URL: https://issues.apache.org/jira/browse/SOLR-1845
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Yonik Seeley
>             Fix For: 3.1
>
>
> The terms component uses a named list instead of simple ordered map for it's top-level data structure.
> Access by name is more important, so it should be a map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-1845) terms component response format uses list instead of map

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849749#action_12849749 ]

Hoss Man commented on SOLR-1845:
--------------------------------

Isn't getting the terms in order more important then being able to look them up in a map?

> terms component response format uses list instead of map
> --------------------------------------------------------
>
>                 Key: SOLR-1845
>                 URL: https://issues.apache.org/jira/browse/SOLR-1845
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Yonik Seeley
>             Fix For: 3.1
>
>
> The terms component uses a named list instead of simple ordered map for it's top-level data structure.
> Access by name is more important, so it should be a map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-1845) terms component response format uses list instead of map

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849754#action_12849754 ]

Yonik Seeley commented on SOLR-1845:
------------------------------------

bq. Isn't getting the terms in order more important then being able to look them up in a map?

Yes - just like faceting.
The proposal is not to change that part, but the top-level terms container.
In the example above "features" is the name of a field.  It's "terms" that changes from a list to a map (the way faceting already is).

> terms component response format uses list instead of map
> --------------------------------------------------------
>
>                 Key: SOLR-1845
>                 URL: https://issues.apache.org/jira/browse/SOLR-1845
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Yonik Seeley
>             Fix For: 3.1
>
>
> The terms component uses a named list instead of simple ordered map for it's top-level data structure.
> Access by name is more important, so it should be a map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-1845) terms component response format uses list instead of map

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-1845:
-------------------------------

    Attachment: SOLR-1845.patch

Attaching patch.
This is mostly a back compat issue for JSON based output formats.

> terms component response format uses list instead of map
> --------------------------------------------------------
>
>                 Key: SOLR-1845
>                 URL: https://issues.apache.org/jira/browse/SOLR-1845
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Yonik Seeley
>             Fix For: 3.1
>
>         Attachments: SOLR-1845.patch
>
>
> The terms component uses a named list instead of simple ordered map for it's top-level data structure.
> Access by name is more important, so it should be a map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-1845) terms component response format uses list instead of map

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849759#action_12849759 ]

Hoss Man commented on SOLR-1845:
--------------------------------

Ah .. sorry, my ignorance of TermsComponent is showing ... i though "features" was a term in the "terms" list for some field (specified higher up outside your snippet)

carry on.

> terms component response format uses list instead of map
> --------------------------------------------------------
>
>                 Key: SOLR-1845
>                 URL: https://issues.apache.org/jira/browse/SOLR-1845
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Yonik Seeley
>             Fix For: 3.1
>
>         Attachments: SOLR-1845.patch
>
>
> The terms component uses a named list instead of simple ordered map for it's top-level data structure.
> Access by name is more important, so it should be a map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-1845) terms component response format uses list instead of map

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley resolved SOLR-1845.
--------------------------------

    Resolution: Fixed

Committed.

> terms component response format uses list instead of map
> --------------------------------------------------------
>
>                 Key: SOLR-1845
>                 URL: https://issues.apache.org/jira/browse/SOLR-1845
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Yonik Seeley
>             Fix For: 3.1
>
>         Attachments: SOLR-1845.patch
>
>
> The terms component uses a named list instead of simple ordered map for it's top-level data structure.
> Access by name is more important, so it should be a map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.