[jira] Created: (SOLR-1981) solr.xml should fail to load if multiple cores with the same name

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-1981) solr.xml should fail to load if multiple cores with the same name

JIRA jira@apache.org
solr.xml should fail to load if multiple cores with the same name
-----------------------------------------------------------------

                 Key: SOLR-1981
                 URL: https://issues.apache.org/jira/browse/SOLR-1981
             Project: Solr
          Issue Type: Improvement
            Reporter: Hoss Man
         Attachments: SOLR-1981.patch

As noted in email a while back...

http://search.lucidimagination.com/search/document/674bf5dfbbb349bc/multiple_cores_w_same_name_in_solr_xml

{quote}
but there is currently no assertion that every core have a name, or that the
names be unique before the SolrCore is constructed ... it's not until the core is registered that an error will be
generated if the core name is null, or that the previous core with an identicle name will be close()ed.
{quote}

I think we should fail fast if solr.xml specifies the same name more then once

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-1981) solr.xml should fail to load if multiple cores with the same name

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-1981:
---------------------------

    Attachment: SOLR-1981.patch

patch I had sitting on my hard drive that tries to deal with this better.

> solr.xml should fail to load if multiple cores with the same name
> -----------------------------------------------------------------
>
>                 Key: SOLR-1981
>                 URL: https://issues.apache.org/jira/browse/SOLR-1981
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-1981.patch
>
>
> As noted in email a while back...
> http://search.lucidimagination.com/search/document/674bf5dfbbb349bc/multiple_cores_w_same_name_in_solr_xml
> {quote}
> but there is currently no assertion that every core have a name, or that the
> names be unique before the SolrCore is constructed ... it's not until the core is registered that an error will be
> generated if the core name is null, or that the previous core with an identicle name will be close()ed.
> {quote}
> I think we should fail fast if solr.xml specifies the same name more then once

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-1981) solr.xml should fail to load if multiple cores with the same name

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884837#action_12884837 ]

Hoss Man commented on SOLR-1981:
--------------------------------

Note: what i'm propossing here actually breaks back-compat in a way that i think is good.

at the moment, if you declare multiple cores with the exact same name, solr will initialize the first, then initialize the second, which will shutdown the first -- in effect, silently ignoring the first declaration.

I'm proposing a hard failure during solr.xml config parsing, before any SolrCores are ever initialized.

> solr.xml should fail to load if multiple cores with the same name
> -----------------------------------------------------------------
>
>                 Key: SOLR-1981
>                 URL: https://issues.apache.org/jira/browse/SOLR-1981
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-1981.patch
>
>
> As noted in email a while back...
> http://search.lucidimagination.com/search/document/674bf5dfbbb349bc/multiple_cores_w_same_name_in_solr_xml
> {quote}
> but there is currently no assertion that every core have a name, or that the
> names be unique before the SolrCore is constructed ... it's not until the core is registered that an error will be
> generated if the core name is null, or that the previous core with an identicle name will be close()ed.
> {quote}
> I think we should fail fast if solr.xml specifies the same name more then once

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-1981) solr.xml should fail to load if multiple cores with the same name

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886373#action_12886373 ]

Mark Miller commented on SOLR-1981:
-----------------------------------

+1 - lets do it

> solr.xml should fail to load if multiple cores with the same name
> -----------------------------------------------------------------
>
>                 Key: SOLR-1981
>                 URL: https://issues.apache.org/jira/browse/SOLR-1981
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-1981.patch
>
>
> As noted in email a while back...
> http://search.lucidimagination.com/search/document/674bf5dfbbb349bc/multiple_cores_w_same_name_in_solr_xml
> {quote}
> but there is currently no assertion that every core have a name, or that the
> names be unique before the SolrCore is constructed ... it's not until the core is registered that an error will be
> generated if the core name is null, or that the previous core with an identicle name will be close()ed.
> {quote}
> I think we should fail fast if solr.xml specifies the same name more then once

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-1981) solr.xml should fail to load if multiple cores with the same name

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-1981:
---------------------------

    Attachment: SOLR-1981.patch

aparently i never actually tested that patch when i wrote it -- i just discovered that it breaks *everything* because i removed the 'name=""' that happens for hte default core.

new patch adds that back, along with a comment about why it's there, and includes a new check to ensure that name is always specified (no NPE if it's missing)

> solr.xml should fail to load if multiple cores with the same name
> -----------------------------------------------------------------
>
>                 Key: SOLR-1981
>                 URL: https://issues.apache.org/jira/browse/SOLR-1981
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-1981.patch, SOLR-1981.patch
>
>
> As noted in email a while back...
> http://search.lucidimagination.com/search/document/674bf5dfbbb349bc/multiple_cores_w_same_name_in_solr_xml
> {quote}
> but there is currently no assertion that every core have a name, or that the
> names be unique before the SolrCore is constructed ... it's not until the core is registered that an error will be
> generated if the core name is null, or that the previous core with an identicle name will be close()ed.
> {quote}
> I think we should fail fast if solr.xml specifies the same name more then once

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-1981) solr.xml should fail to load if multiple cores with the same name

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man resolved SOLR-1981.
----------------------------

         Assignee: Hoss Man
    Fix Version/s: 3.1
                   4.0
       Resolution: Fixed

Committed revision 962714.  ... trunk

Committed revision 962721. ... branch 3x

> solr.xml should fail to load if multiple cores with the same name
> -----------------------------------------------------------------
>
>                 Key: SOLR-1981
>                 URL: https://issues.apache.org/jira/browse/SOLR-1981
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-1981.patch, SOLR-1981.patch
>
>
> As noted in email a while back...
> http://search.lucidimagination.com/search/document/674bf5dfbbb349bc/multiple_cores_w_same_name_in_solr_xml
> {quote}
> but there is currently no assertion that every core have a name, or that the
> names be unique before the SolrCore is constructed ... it's not until the core is registered that an error will be
> generated if the core name is null, or that the previous core with an identicle name will be close()ed.
> {quote}
> I think we should fail fast if solr.xml specifies the same name more then once

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]