[jira] Created: (SOLR-2057) DataImportHandler never calls UpdateRequestProcessor.finish()

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-2057) DataImportHandler never calls UpdateRequestProcessor.finish()

JIRA jira@apache.org
DataImportHandler never calls UpdateRequestProcessor.finish()
-------------------------------------------------------------

                 Key: SOLR-2057
                 URL: https://issues.apache.org/jira/browse/SOLR-2057
             Project: Solr
          Issue Type: Bug
          Components: contrib - DataImportHandler
    Affects Versions: 1.4.1, 3.1, 4.0
            Reporter: Drew Farris
            Priority: Minor


I was experimenting with custom UpdateRequestProcessor implementations and noticed that the sample LogUpdateProcessorFactory's finish method wasn't being called. I tracked this back down to the fact that SolrWriter in the data import handler never calls the finish() method on its UpdateRequestProcessor.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2057) DataImportHandler never calls UpdateRequestProcessor.finish()

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Drew Farris updated SOLR-2057:
------------------------------

    Attachment: SOLR-2057.patch

This patch against branch_3x adds a finish() method to SolrWriter which in turn calls UpdateRequestProcessor.finish().

It appears that other classes call finish() regardless of the update's final state, so I added a call to finish to DocBuilder in what seems like an appropriate location near the end of execute()

Updated unit tests to add a TestUpdateRequestProcessor, and validate that the appropriate methods are being called in the major cases.

> DataImportHandler never calls UpdateRequestProcessor.finish()
> -------------------------------------------------------------
>
>                 Key: SOLR-2057
>                 URL: https://issues.apache.org/jira/browse/SOLR-2057
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4.1, 3.1, 4.0
>            Reporter: Drew Farris
>            Priority: Minor
>         Attachments: SOLR-2057.patch
>
>
> I was experimenting with custom UpdateRequestProcessor implementations and noticed that the sample LogUpdateProcessorFactory's finish method wasn't being called. I tracked this back down to the fact that SolrWriter in the data import handler never calls the finish() method on its UpdateRequestProcessor.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (SOLR-2057) DataImportHandler never calls UpdateRequestProcessor.finish()

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Sekiguchi reassigned SOLR-2057:
------------------------------------

    Assignee: Koji Sekiguchi

> DataImportHandler never calls UpdateRequestProcessor.finish()
> -------------------------------------------------------------
>
>                 Key: SOLR-2057
>                 URL: https://issues.apache.org/jira/browse/SOLR-2057
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4.1, 3.1, 4.0
>            Reporter: Drew Farris
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>         Attachments: SOLR-2057.patch, SOLR-2057.patch
>
>
> I was experimenting with custom UpdateRequestProcessor implementations and noticed that the sample LogUpdateProcessorFactory's finish method wasn't being called. I tracked this back down to the fact that SolrWriter in the data import handler never calls the finish() method on its UpdateRequestProcessor.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2057) DataImportHandler never calls UpdateRequestProcessor.finish()

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Sekiguchi updated SOLR-2057:
---------------------------------

    Attachment: SOLR-2057.patch

Thank you for contributing the patch, Drew. Looks great!

I needed to change the update processor class name in contentstream-solrconfig.xml to pass test.
I'll commit in a few days.

> DataImportHandler never calls UpdateRequestProcessor.finish()
> -------------------------------------------------------------
>
>                 Key: SOLR-2057
>                 URL: https://issues.apache.org/jira/browse/SOLR-2057
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4.1, 3.1, 4.0
>            Reporter: Drew Farris
>            Priority: Minor
>         Attachments: SOLR-2057.patch, SOLR-2057.patch
>
>
> I was experimenting with custom UpdateRequestProcessor implementations and noticed that the sample LogUpdateProcessorFactory's finish method wasn't being called. I tracked this back down to the fact that SolrWriter in the data import handler never calls the finish() method on its UpdateRequestProcessor.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-2057) DataImportHandler never calls UpdateRequestProcessor.finish()

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Sekiguchi resolved SOLR-2057.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0
                   3.1

trunk: Committed revision 1030098.
branch_3x: Committed revision 1030114.

Thanks, Drew!

> DataImportHandler never calls UpdateRequestProcessor.finish()
> -------------------------------------------------------------
>
>                 Key: SOLR-2057
>                 URL: https://issues.apache.org/jira/browse/SOLR-2057
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4.1, 3.1, 4.0
>            Reporter: Drew Farris
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2057.patch, SOLR-2057.patch
>
>
> I was experimenting with custom UpdateRequestProcessor implementations and noticed that the sample LogUpdateProcessorFactory's finish method wasn't being called. I tracked this back down to the fact that SolrWriter in the data import handler never calls the finish() method on its UpdateRequestProcessor.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]