[jira] Created: (SOLR-2110) Distributed faceting can create invalid refinement requests when "key" is complex

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-2110) Distributed faceting can create invalid refinement requests when "key" is complex

JIRA jira@apache.org
Distributed faceting can create invalid refinement requests when "key" is complex
---------------------------------------------------------------------------------

                 Key: SOLR-2110
                 URL: https://issues.apache.org/jira/browse/SOLR-2110
             Project: Solr
          Issue Type: Bug
            Reporter: Yonik Seeley
            Priority: Minor


The NPE described here: http://search.lucidimagination.com/search/document/a4c217d153635301
is due to 2 issues.  An exception in a refinement request isn't checked for, and a NPE results, masking the original exception.
The original exception is caused by Solr using local param dereferencing with a param name derived from the "key" for that facet.
If the key is something like "a/b/c" the request fails.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2110) Distributed faceting can create invalid refinement requests when "key" is complex

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907226#action_12907226 ]

Yonik Seeley commented on SOLR-2110:
------------------------------------

Proposed fixes:
 - check for facet/exception (or the lack of facet/facet_fields)
 - the generated param name for listing the refinement terms should be mangled/escaped to ensure correct syntax
 - OPTIONAL: param dereferencing should be able to support the full range of values (right now it's just an "id")

> Distributed faceting can create invalid refinement requests when "key" is complex
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-2110
>                 URL: https://issues.apache.org/jira/browse/SOLR-2110
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Priority: Minor
>
> The NPE described here: http://search.lucidimagination.com/search/document/a4c217d153635301
> is due to 2 issues.  An exception in a refinement request isn't checked for, and a NPE results, masking the original exception.
> The original exception is caused by Solr using local param dereferencing with a param name derived from the "key" for that facet.
> If the key is something like "a/b/c" the request fails.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2110) Distributed faceting can create invalid refinement requests when "key" is complex

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907444#action_12907444 ]

Yonik Seeley commented on SOLR-2110:
------------------------------------

part 1 (SOLR-2111) is done and committed.
I think we should be able to support more than just a normal "id" for param dereferencing (part 3) - the docs never said anything about restrictions.

> Distributed faceting can create invalid refinement requests when "key" is complex
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-2110
>                 URL: https://issues.apache.org/jira/browse/SOLR-2110
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Priority: Minor
>
> The NPE described here: http://search.lucidimagination.com/search/document/a4c217d153635301
> is due to 2 issues.  An exception in a refinement request isn't checked for, and a NPE results, masking the original exception.
> The original exception is caused by Solr using local param dereferencing with a param name derived from the "key" for that facet.
> If the key is something like "a/b/c" the request fails.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2110) Distributed faceting can create invalid refinement requests when "key" is complex

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-2110:
-------------------------------

    Attachment: SOLR-2110.patch

> Distributed faceting can create invalid refinement requests when "key" is complex
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-2110
>                 URL: https://issues.apache.org/jira/browse/SOLR-2110
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Priority: Minor
>         Attachments: SOLR-2110.patch
>
>
> The NPE described here: http://search.lucidimagination.com/search/document/a4c217d153635301
> is due to 2 issues.  An exception in a refinement request isn't checked for, and a NPE results, masking the original exception.
> The original exception is caused by Solr using local param dereferencing with a param name derived from the "key" for that facet.
> If the key is something like "a/b/c" the request fails.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2110) Distributed faceting can create invalid refinement requests when "key" is complex

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907453#action_12907453 ]

Yonik Seeley commented on SOLR-2110:
------------------------------------

OK, here's a draft patch that removes any restriction on dereferencing in local params.
If the first char is a $, then the value will be treated as a parameter name and dereferenced.  The value is read like any other value... may be quoted, etc.

so legal examples are
foo=$a/b/c
foo=$'a/b/c'

> Distributed faceting can create invalid refinement requests when "key" is complex
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-2110
>                 URL: https://issues.apache.org/jira/browse/SOLR-2110
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Priority: Minor
>         Attachments: SOLR-2110.patch
>
>
> The NPE described here: http://search.lucidimagination.com/search/document/a4c217d153635301
> is due to 2 issues.  An exception in a refinement request isn't checked for, and a NPE results, masking the original exception.
> The original exception is caused by Solr using local param dereferencing with a param name derived from the "key" for that facet.
> If the key is something like "a/b/c" the request fails.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2110) Distributed faceting can create invalid refinement requests when "key" is complex

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907458#action_12907458 ]

Yonik Seeley commented on SOLR-2110:
------------------------------------

I added tests and committed the patch to remove restrictions on what can be dereferenced in local params.

> Distributed faceting can create invalid refinement requests when "key" is complex
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-2110
>                 URL: https://issues.apache.org/jira/browse/SOLR-2110
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Priority: Minor
>         Attachments: SOLR-2110.patch
>
>
> The NPE described here: http://search.lucidimagination.com/search/document/a4c217d153635301
> is due to 2 issues.  An exception in a refinement request isn't checked for, and a NPE results, masking the original exception.
> The original exception is caused by Solr using local param dereferencing with a param name derived from the "key" for that facet.
> If the key is something like "a/b/c" the request fails.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (SOLR-2110) Distributed faceting can create invalid refinement requests when "key" is complex

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley closed SOLR-2110.
------------------------------

    Fix Version/s: 4.0
       Resolution: Fixed

Committed escaping code for keys we internally generate (or re-generate).  That should finish up this issue.

> Distributed faceting can create invalid refinement requests when "key" is complex
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-2110
>                 URL: https://issues.apache.org/jira/browse/SOLR-2110
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2110.patch
>
>
> The NPE described here: http://search.lucidimagination.com/search/document/a4c217d153635301
> is due to 2 issues.  An exception in a refinement request isn't checked for, and a NPE results, masking the original exception.
> The original exception is caused by Solr using local param dereferencing with a param name derived from the "key" for that facet.
> If the key is something like "a/b/c" the request fails.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Reopened: (SOLR-2110) Distributed faceting can create invalid refinement requests when "key" is complex

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Sekiguchi reopened SOLR-2110:
----------------------------------

      Assignee: Yonik Seeley

I need this fix for branch_3x.

> Distributed faceting can create invalid refinement requests when "key" is complex
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-2110
>                 URL: https://issues.apache.org/jira/browse/SOLR-2110
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2110.patch
>
>
> The NPE described here: http://search.lucidimagination.com/search/document/a4c217d153635301
> is due to 2 issues.  An exception in a refinement request isn't checked for, and a NPE results, masking the original exception.
> The original exception is caused by Solr using local param dereferencing with a param name derived from the "key" for that facet.
> If the key is something like "a/b/c" the request fails.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-2110) Distributed faceting can create invalid refinement requests when "key" is complex

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Sekiguchi resolved SOLR-2110.
----------------------------------

    Resolution: Fixed

branch_3x: Committed revision 1003506.

> Distributed faceting can create invalid refinement requests when "key" is complex
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-2110
>                 URL: https://issues.apache.org/jira/browse/SOLR-2110
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2110.patch
>
>
> The NPE described here: http://search.lucidimagination.com/search/document/a4c217d153635301
> is due to 2 issues.  An exception in a refinement request isn't checked for, and a NPE results, masking the original exception.
> The original exception is caused by Solr using local param dereferencing with a param name derived from the "key" for that facet.
> If the key is something like "a/b/c" the request fails.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2110) Distributed faceting can create invalid refinement requests when "key" is complex

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Sekiguchi updated SOLR-2110:
---------------------------------

    Fix Version/s: 3.1

> Distributed faceting can create invalid refinement requests when "key" is complex
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-2110
>                 URL: https://issues.apache.org/jira/browse/SOLR-2110
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2110.patch
>
>
> The NPE described here: http://search.lucidimagination.com/search/document/a4c217d153635301
> is due to 2 issues.  An exception in a refinement request isn't checked for, and a NPE results, masking the original exception.
> The original exception is caused by Solr using local param dereferencing with a param name derived from the "key" for that facet.
> If the key is something like "a/b/c" the request fails.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]