[jira] Created: (SOLR-2111) treat facet exceptions consistently

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-2111) treat facet exceptions consistently

JIRA jira@apache.org
treat facet exceptions consistently
-----------------------------------

                 Key: SOLR-2111
                 URL: https://issues.apache.org/jira/browse/SOLR-2111
             Project: Solr
          Issue Type: Bug
            Reporter: Yonik Seeley


Right now, faceting on a non-existent field will just add an "exception" to the facet_counts.
In distrib mode, it will cause the whole request to fail.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2111) treat facet exceptions consistently

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907257#action_12907257 ]

Yonik Seeley commented on SOLR-2111:
------------------------------------

I'm also thinking that as long as we are treating facet exceptions in this way, an exception should be caught per facet-command (i.e. the first exception should not prevent the next facet command from completing).

> treat facet exceptions consistently
> -----------------------------------
>
>                 Key: SOLR-2111
>                 URL: https://issues.apache.org/jira/browse/SOLR-2111
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>
> Right now, faceting on a non-existent field will just add an "exception" to the facet_counts.
> In distrib mode, it will cause the whole request to fail.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2111) treat facet exceptions consistently

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907272#action_12907272 ]

Yonik Seeley commented on SOLR-2111:
------------------------------------

The direction I'm currently thinking of taking on this is to change facet_counts/exception to a List<String> (from a single String now) to support listing multiple exceptions.


> treat facet exceptions consistently
> -----------------------------------
>
>                 Key: SOLR-2111
>                 URL: https://issues.apache.org/jira/browse/SOLR-2111
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>
> Right now, faceting on a non-existent field will just add an "exception" to the facet_counts.
> In distrib mode, it will cause the whole request to fail.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2111) treat facet exceptions consistently

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-2111:
-------------------------------

    Attachment: SOLR-2111.patch

Here's a patch that implements the suggestion above: "exception" is now a list, an exception in one faceting command doesn't cause the preceding ones to fail, and all shard faceting exceptions are added during aggregation.

> treat facet exceptions consistently
> -----------------------------------
>
>                 Key: SOLR-2111
>                 URL: https://issues.apache.org/jira/browse/SOLR-2111
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>         Attachments: SOLR-2111.patch
>
>
> Right now, faceting on a non-existent field will just add an "exception" to the facet_counts.
> In distrib mode, it will cause the whole request to fail.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-2111) treat facet exceptions consistently

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley resolved SOLR-2111.
--------------------------------

    Fix Version/s: 4.0
       Resolution: Fixed

committed.

> treat facet exceptions consistently
> -----------------------------------
>
>                 Key: SOLR-2111
>                 URL: https://issues.apache.org/jira/browse/SOLR-2111
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>             Fix For: 4.0
>
>         Attachments: SOLR-2111.patch
>
>
> Right now, faceting on a non-existent field will just add an "exception" to the facet_counts.
> In distrib mode, it will cause the whole request to fail.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2111) treat facet exceptions consistently

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Sekiguchi updated SOLR-2111:
---------------------------------

    Fix Version/s: 3.1

back port to branch_3x.

> treat facet exceptions consistently
> -----------------------------------
>
>                 Key: SOLR-2111
>                 URL: https://issues.apache.org/jira/browse/SOLR-2111
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2111.patch
>
>
> Right now, faceting on a non-existent field will just add an "exception" to the facet_counts.
> In distrib mode, it will cause the whole request to fail.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]